Fix Mahjong hu check for exposed sets without pair#339
Open
Jiang020609 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a Mahjong hu judgment edge case.
Previously, MahjongJudger.judge_hu returned True whenever len(player.pile) >= 4.
That can mark a hand as winning even when the concealed remaining tiles do not
contain a pair.
Example: after four exposed melds, a remaining hand like [dots-6, bamboo-4]
was judged as hu.
This patch removes the early win return and requires the existing pair-check
path to validate the remaining concealed hand.
Tests added:
Local test:
python -m pytest tests/games/test_mahjong_game.py tests/envs/test_mahjong.py
Result:
17 passed