Skip to content

feat: Add databricks_lakebase to DatabaseType enum#5

Merged
jiatolentino merged 1 commit into
datamasque:mainfrom
jiatolentino:DM-3518-add-databricks_lakebase-database-types
May 10, 2026
Merged

feat: Add databricks_lakebase to DatabaseType enum#5
jiatolentino merged 1 commit into
datamasque:mainfrom
jiatolentino:DM-3518-add-databricks_lakebase-database-types

Conversation

@jiatolentino
Copy link
Copy Markdown
Contributor

Summary

  • Adds databricks_lakebase to the DatabaseType enum in datamasque/client/models/connection.py

Context

Databricks Lakebase is a fully managed Postgres-compatible OLTP database currently in development support in DataMasque. This change adds databricks_lakebase as a valid database type in the Python client ahead of the full release.

@jiatolentino jiatolentino marked this pull request as draft May 8, 2026 03:28
@jiatolentino jiatolentino self-assigned this May 8, 2026
@jiatolentino jiatolentino marked this pull request as ready for review May 8, 2026 03:44
@cph-datamasque
Copy link
Copy Markdown
Collaborator

Consider adding a UT to check we can deserialize this and the result is a regular DatabaseConnectionConfig.

Otherwise, approved, presuming that Databricks Lakebase connection options are the same as for regular databases (postgres, mssql etc).

@jiatolentino jiatolentino force-pushed the DM-3518-add-databricks_lakebase-database-types branch from 665cadf to d08db1e Compare May 10, 2026 21:11
@jiatolentino
Copy link
Copy Markdown
Contributor Author

Hi @cph-datamasque. I've added the UT as recommended and also updated the date in HISTORY.rst.

@jiatolentino jiatolentino merged commit c626b50 into datamasque:main May 10, 2026
8 checks passed
@jiatolentino jiatolentino deleted the DM-3518-add-databricks_lakebase-database-types branch May 10, 2026 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants