Clean and automate native-image metadata#1887
Conversation
PR Summary
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
============================================
+ Coverage 92.44% 92.49% +0.05%
- Complexity 3566 3568 +2
============================================
Files 347 347
Lines 7051 7051
Branches 675 675
============================================
+ Hits 6518 6522 +4
+ Misses 369 366 -3
+ Partials 164 163 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
I have zero insight/knowledge on this |
yeah, same, but I made an native build using Codex, and it mentioned that our image is too big. This was the context Codex gave me: I've built an new app now using Datafaker as a native build with the updated version of Datafaker, and it works fine, so I think it's fine. |
|
I'm just gonna assume you approved it. Thanks @kingthorin ;-) |
Summary
Root cause
The checked-in metadata was generated from the full test process without sufficient filtering. That allowed JUnit, Mockito, Byte Buddy, IDE, and test fixture metadata to leak into the library artifact. Resource discovery was also dependent on which paths happened to execute during tests.
Validation
JAVA_HOME=/Users/erikpragt/.sdkman/candidates/java/current ./scripts/update-native-image-metadata.sh--no-fallbackGET /personsreturned 10 generated people, including phone and address datagit diff --checkand JSON syntax validation