Repository navigation
Stage compat/ and stop ignoring examples/ and compat/ in app deploy - #501
Closed
sundarleads wants to merge 1 commit into
Closed
sundarleads wants to merge 1 commit into
sundarleads wants to merge 1 commit into
Conversation
setup.py needs examples/ (MCP templates) and compat/ (dlt_meta and src packages) to build the wheel when the App starts. issue_500 already stages examples/. This adds compat/ to both deploy scripts and removes compat/ and examples/ from .databricksignore, which the scripts stage for databricks sync. The new test checks that both scripts stage every directory setup.py needs, and that .databricksignore does not exclude any of them.
Contributor
|
Thank you for the follow-up. This fix is already present on the target Closing this PR as a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #500, now against issue_500.
issue_500 already stages examples/, so this adds compat/ to both deploy scripts and drops compat/ and examples/ from .databricksignore so sync doesn't skip them.
I also extended the staging test to check .databricksignore against the dirs setup.py needs. It fails on current issue_500 and passes with this change. flake8 and bandit are clean. Haven't run the .ps1 on Windows, it's a one-line change.