Support invoking the action twice in the same job#251
Merged
Conversation
Calling the action twice in one job failed: both runs shared $RUNNER_TEMP/.bin, so the second unzip hit a non-interactive overwrite prompt and exited 1. Each invocation now downloads into its own mktemp -d "$RUNNER_TEMP/databricks.XXXXXX" dir. A unique per-invocation dir keeps us fully isolated from other actions sharing $RUNNER_TEMP, and lets repeated calls coexist without deleting anything. Co-authored-by: Isaac
Cite the Variables reference, which documents that $RUNNER_TEMP is emptied at the beginning and end of each job -- explaining why the per-invocation directories need no manual cleanup. Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
simonfaltum
approved these changes
Jun 15, 2026
simonfaltum
left a comment
simonfaltum
left a comment
Member
There was a problem hiding this comment.
Approved. I reviewed the release and snapshot installer changes and did not find any blocking issues.
Verification:
- Ran
bash -n setup_release.sh setup_snapshot.shlocally. - Checked PR status with
gh pr checks 251 --repo databricks/setup-cli; all checks passed. - Confirmed the new
action_twicematrix passed on macOS, Ubuntu, and Windows. - Confirmed CI
shellcheckpassed; localshellcheckis not installed on this machine, so I relied on the GitHub check for that.
Drop the gh-run-download/Windows-rename aside from the snapshot comment and fold the $RUNNER_TEMP cleanup note back into the main paragraph in both scripts. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling the action twice in one job failed: both runs shared
$RUNNER_TEMP/.bin, so the secondunziphit a non-interactive overwrite prompt and exited 1.Each invocation now downloads into its own
mktemp -d "$RUNNER_TEMP/databricks.XXXXXX"dir. A unique per-invocation dir keeps us fully isolated from other actions sharing$RUNNER_TEMP, and lets repeated calls coexist without deleting anything.setup_release.sh/setup_snapshot.sh: unique temp dir per invocation.test.yml: newaction_twicejob (macOS/Ubuntu/Windows) invokes the action twice and asserts version + clean tree.Closes #186
Closes #136
This pull request and its description were written by Isaac.