Skip to content

[checks] Require package:meta ^1.17.0 - #2779

Merged
natebosch merged 1 commit into
masterfrom
checks-lower-bound
Oct 7, 2026
Merged

natebosch merged 1 commit into
masterfrom
checks-lower-bound

Conversation

@kevmoo

@kevmoo kevmoo commented Oct 7, 2026

Copy link
Copy Markdown
Member

Rationale

pkgs/checks/lib/src/extensions/async.dart and pkgs/checks/lib/src/extensions/function.dart use @awaitNotRequired, which was introduced in package:meta 1.17.0, while pubspec.yaml currently declares meta: ^1.9.0. Resolving at the declared lower bound fails static analysis (Undefined name 'awaitNotRequired').

Summary of Changes

  • Raise meta lower bound from ^1.9.0 to ^1.17.0 in pkgs/checks/pubspec.yaml.
  • Note package:meta ^1.17.0 requirement under 0.4.0-wip in pkgs/checks/CHANGELOG.md.

Verification

  • Verified dart analyze --fatal-infos and dart test (431 tests) pass in pkgs/checks.
  • Verified lower-bound compilation passes at meta: 1.17.0 using package:lower_bound.

`lib/src/extensions/async.dart` and `lib/src/extensions/function.dart` use `@awaitNotRequired`, which was introduced in `package:meta` 1.17.0.
@kevmoo
kevmoo requested a review from a team as a code owner October 7, 2026 07:23
@github-actions github-actions Bot added the package:checks Issues related to pkg:checks label Oct 7, 2026
@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@natebosch
natebosch merged commit c4b165b into master Oct 7, 2026
166 of 169 checks passed
@natebosch
natebosch deleted the checks-lower-bound branch October 7, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package:checks Issues related to pkg:checks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants