Repository navigation
Wtc60 config pr - #440
Draft
guido4096 wants to merge 3 commits into
Draft
Wtc60 config pr#440guido4096 wants to merge 3 commits into
guido4096 wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add raw decoders for the observed WTC-60 broadcasts and let passive zero-payload commands produce named log entries. Document the separate StringPool capacity prerequisite. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Replace house-specific room labels with circuit numbers in command names and documentation while preserving command keys and protocol definitions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
07FFsign-of-life message.Circuit_2,Circuit_3, andCircuit_4labels while preserving command keys, telegrams, and field semantics.Why
command_managerchanges are requiredThe
07FFsign-of-life telegram has no payload: its master frame declares a data length of zero.CommandManager::updateData()previously returned immediately for commands with no configured fields. That means a passive command could match the telegram prefix, but the update path discarded it before recording a session or invoking the decoded-command log callback. It consequently appeared only as a raw telegram, not as the namedWeishaupt/Bus/Sign_of_lifecommand.This change keeps normal field decoding unchanged and adds a narrow event path for passive commands that intentionally have no fields: it accepts only zero-payload messages, records the timestamp/session, and invokes the existing log callback. It does not create data or publish a fabricated value. Active no-field commands and no-field commands receiving a nonzero payload are ignored. The regression test verifies the named match, empty data, recorded session, log output, and rejection of a payload-bearing variant.
Capacity prerequisite
The complete WTC-60 set now contains 93 commands and uses approximately 6355 bytes for unique keys/names/field names.
mastercurrently has a 2048-byte StringPool. In the current setup you cannot deploy all commands, you will to increase the StringPoolValidation