Conversation
CAN PDU Signal Extraction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for CAN-FD to ASAMMDF. Added extraction of PDU signals from CAN-FD frame. To maintain compatibility, I had to refactor the existing CAN frame handling code to support both traditional CAN and CAN-FD frames seamlessly. For that, I made changes in existing extract_can_logging function and creating new function for pdus in bus_loggin_utils script. I have tested this changes with mdf file, which has CAN and CAN-FD signals.
Please review and let me know if any further changes or adjustments are needed. I'm open to feedback and eager to collaborate to ensure the successful integration of CAN-FD support into ASAMMDF.