Conversation
FileWidget.__init__ read file_name.suffix before the existing Path(file_name) conversion further down, so passing a str raised AttributeError. Convert first.
…rt test The file widget's selected_filter_channels is a QTreeWidget, the test still used the QListWidget count()/item() API.
The tests workflow fails on windows-latest with 'CMAKE_C_COMPILER not set' while building the sdist. Apply the same setup steps that fixed the pyinstaller_build workflow in danielhrisca#1310.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
testsworkflow fails ondevelopmentfor several independent reasons. This fixes the ones with a clear cause. The mypy job still fails on Python 3.10 and 3.13, so thetestscheck as a whole stays red there (see below).FileWidgetwith astrpath.FileWidget.__init__readfile_name.suffixbefore convertingfile_nameto aPath, so every GUI test that passes astr(the test helper does, viashutil.copy) failed withAttributeError: 'str' object has no attribute 'suffix'. The regression came in with fix: handle None channel comment when encoding metadata #1301. ThePathconversion now happens first.test_FileWidget_TabModifyAndExportused theQListWidgetAPI (.count(),.item()) onselected_filter_channels, which is aQTreeWidgetin the file widget. It was hidden behind thesuffixerror. It now usestopLevelItemCount()/topLevelItem()/text(0).CMAKE_C_COMPILER not set(CMake picks the NMake generator). Same setup steps aspyinstaller_buildfrom fix: unblock test collection and Windows pyinstaller build #1310 (Ninja + Visual Studio 2022 Build Tools). With this the Windows jobs get through the build and run the test suite. Some of these steps may turn out to be redundant and can be trimmed afterwards.ruff format --checkfailed ongui/utils.py(trailing whitespace only).Result on this PR
ruffanddocare OK.test_PlotWidget_ContextMenu::test_Action_CopyChannelStructure_Group, blocked indrag.exec()(gui/widgets/tree.py). The same test passes on the other three Windows jobs in the same run, so this looks like a flaky drag-and-drop hang unrelated to this change.Not addressed