Add plan comments - #955
Conversation
|
@Florian-Cullmann could you please take the comments made in #720 into account? |
|
@pgiraud on it! |
|
@pgiraud done |
|
If it doesn't bother you to make a small change, I'd be in favor of not adding the While you're at it, can you please, in an additional commit, move the |
e532999 to
b9abc07
Compare
|
@pgiraud done |
|
Can you please make it so the Also, can you please squash the 3 first commits and create one single "Add plan comments" commit? |
|
Do you think you'll be able to work on this soon? I'd like to publish a new release. |
b9abc07 to
354e37d
Compare
|
@pgiraud Done - I moved the sample plans selector next to the Plan Name label and squashed the first three commits. Does this look good to you? |
|
Thanks a lot for your contribution to the project. |
Summary
plan-commentprop to the reusable Plan componentWhy
PEV2 only carried the plan source and SQL query through its component and demo data flows, so users had no dedicated place to keep context such as configuration differences or tuning notes. Comments are now stored separately from SQL and shown in their own tab with their original line breaks.
Impact
Existing integrations and previously saved plans remain compatible because the new component prop and stored comment value are optional.
Closes #720