feat: reader modal v3 experiment#6203
Open
rebelchris wants to merge 5 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The earlier updateFlags context method forced new members onto settings test fixtures, which surfaced their pre-existing strict violations (missing gamification props, untyped growthbook imports). Switch the two reader-enable call sites to a single setSettings merge instead, reverting the context method and all fixture mocks back to main so they leave the strict-changed diff. Two updateFlag calls were not an option — they race on a shared settings snapshot. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
idoshamun
reviewed
Jun 17, 2026
| !isLegacyLayoutOptedOut; | ||
| // Once a user opts out (via the install-prompt overlay or settings) the card | ||
| // reverts to the classic external Read post button. | ||
| const isReaderVariant = isReaderEnabled && post.type === PostType.Article; |
Member
There was a problem hiding this comment.
Should we allow it for shared post of type article as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Events
Did you introduce any new tracking events?
Experiment
Did you introduce any new experiments?
Manual Testing
Caution
Please make sure existing components are not breaking/affected by this PR
Preview domain
https://feat-reader-modal-v3.preview.app.daily.dev