Conversation
`Restriction::getByTargetId()` returns null (not an exception) when no restriction row exists for the asset. The following `$restriction->getRelatedGroups()` then throws an \Error, which is not caught by the surrounding `catch (\Exception)` -> uncaught fatal. Guard the null case (no restriction -> no related groups), consistent with the protected-storage fallback right below. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
Author
|
Withdrawing — on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
In
RestrictionUri::getAssetUrlInformation():Restriction::getByTargetId()returns null (not a thrown exception) when there is no restriction row for the asset — the common case of an asset in a protected folder without an explicit restriction record.$restriction->getRelatedGroups()then throws\Error, which is not caught by thecatch (\Exception)above (Error is not an Exception), so it surfaces as an uncaught fatal.Fix
Guard the null case (no restriction → no related groups), consistent with the "restricted mode without any restriction settings → empty groups" handling immediately below.