Skip to content

Fix Apple modifier fallback for unavailable platform hints - #725

Merged
czarandy merged 1 commit into
mainfrom
fix/643-apple-mod-fallback
Oct 14, 2026
Merged

czarandy merged 1 commit into
mainfrom
fix/643-apple-mod-fallback

Conversation

@czarandy

Copy link
Copy Markdown
Owner

When client hints report a missing, blank, or Unknown platform on an Apple device, Kbd now displays Command and useHotkey matches Command shortcuts by falling back to navigator.platform. Nonempty, known hints continue to take precedence, including non-Apple hints.

Adds regression coverage for both consumers, accessible Kbd labels, exact hotkey modifiers, malformed hints, Apple device fallbacks, and environments without a navigator. Existing platform-adaptive Kbd stories cover the unchanged UI.

Closes #643.

Validation:

  • All 103 targeted tests passed; the new tests reproduced 18 failures before the fix.
  • Changed-file ESLint, TypeScript, formatting, library build, and package consumer smoke test passed.
  • Full suite hit unrelated timeouts under contention. Stopped remaining local validation at the user's request to release RAM; full-suite, repository lint, and site-build results are left to CI.

@vercel

vercel Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
silver-ui-site Ready Ready Preview Oct 14, 2026 12:30am UTC
1 Skipped Deployment
Project Deployment Actions Updated
silver-ui Ignored Ignored Preview Oct 14, 2026 12:30am UTC

@czarandy
czarandy merged commit c2e4fc1 into main Oct 14, 2026
4 checks passed
@czarandy
czarandy deleted the fix/643-apple-mod-fallback branch October 14, 2026 00:38

This branch was successfully deployed

1 active deployment
Preview – silver-ui-site — 4a531249 Deployed Oct 14, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Empty or Unknown client-hints platform breaks Apple mod shortcuts and Kbd labels

1 participant