Repository navigation
Fix sortable table header alignment - #724
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sortable table headers now align their label, sort icon, and multi-sort priority with the column's
alignsetting. The button uses a Pandacvarecipe with logical start/end justification, so alignment follows LTR and RTL direction.Adds interactive Storybook examples for start/center/end columns in both directions and 32 Chromium layout cases covering default/start/center/end alignment with unsorted, ascending, descending, and multi-sort states. The browser tests reproduced 16 center/end failures before the fix.
Validation passed locally:
pnpm build:storybookgit diff --checkThe full suite and remaining quality/site checks are deferred to CI at the user's request to preserve local RAM. Before stopping the full run, an existing ESLint-rule test (
allows isNonEmptyReactNode checks) exceeded its timeout under concurrent load.Fixes #647.