test(dbop): cover empty retrieved GTID sets - #948
Draft
ahcrm-core wants to merge 1 commit into
Draft
ahcrm-core wants to merge 1 commit into
ahcrm-core wants to merge 1 commit into
Conversation
Signed-off-by: Arafat K. El Haroun <320951795+ahcrm-core@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add regression coverage for
FindTopRunnerwhenRetrievedGtidSetis empty. The test verifies thatExecutedGtidSetis used to select the most advanced runner, as described in #634.This changes tests only; production code is unchanged.
Verification
go test ./pkg/dbop— package compiles successfully; the MySQL-backed suite is skipped withoutTEST_MYSQL=1go vet ./pkg/dbop— passedgit diff --check— passedTEST_MYSQL=1was attempted locally but could not start because Docker is unavailable in the environment; the functional result is intentionally left to repository CIFixes #634