Skip to content

fix: server icons survive a disk cleaner, and an allow list keeps Plug's search tool - #345

Merged
cyberpapiii merged 1 commit into
mainfrom
ship/server-icons-survive-a-disk-cleaner-and-an-allow
Oct 7, 2026
Merged

cyberpapiii merged 1 commit into
mainfrom
ship/server-icons-survive-a-disk-cleaner-and-an-allow

Conversation

@cyberpapiii

@cyberpapiii cyberpapiii commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

What

Server icons, and the fixes from an audit of everything changed since 0.10.0.

  • Icons. Found icons were kept in the system cache, which a disk cleaner empties. The search that refetched them at launch was cancelled when the server list settled, and the cancel was stored as "no icon" for a day. Found icons now sit beside the chosen ones, and a cancelled search stores nothing.
  • Allow list. A client with an allow list keeps Plug's own search tool. Removing a server takes it off every allow list, and an emptied list still holds. A watch on a tool not listed right now is checked by server and tool.
  • Sign-in. A replayed renewal token ends the sign-in in memory even when the save fails.
  • Tasks. A task called by its server's own tool name records its server, so its large result is readable by the client that ran it.
  • Cleanup. One duplicate access check removed, one client key built by the shared helper, one repeated session check named, and two process spawns skipped when their answer is not needed.

Checked

./scripts/dev.sh (all lanes), ./scripts/dev-install.sh, icons present after install.

🤖 Generated with Claude Code

…g's search tool

Found icons are kept beside the chosen ones, and a cancelled search is not
remembered as no icon. From an audit of the changes since 0.10.0: an allow
list no longer hides Plug's own search tool, removing a server takes it off
allow lists, a replayed renewal token ends the sign-in even when the save
fails, and a task called by upstream name records its server. Duplicate
helpers and two needless process spawns are gone.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@cyberpapiii
cyberpapiii enabled auto-merge (squash) October 7, 2026 18:11
@cyberpapiii
cyberpapiii merged commit 2abc637 into main Oct 7, 2026
8 checks passed
@cyberpapiii
cyberpapiii deleted the ship/server-icons-survive-a-disk-cleaner-and-an-allow branch October 7, 2026 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant