Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
goreportcard.comis confirmed sunset: its front page now reads "After more than a decade, Go Report Card has been sunset."I removed the badge from
README.mdand also the## Go Report Cardsection fromCLAUDE.md, which instructed maintaining an A+ grade on the same retired service. That is slightly wider than the ticket's wording, but everything that section enforced is already in the CI section above it (gofmt, gocyclo, ineffassign, misspell, LICENSE), andgo_vetis covered by golangci-lint's defaultgovetlinter, so nothing enforceable was lost.All CI checks pass: gofmt, go vet, golangci-lint (0 issues), gocyclo, ineffassign, misspell, govulncheck (0 vulnerabilities called), and the full test suite.
One environment problem, unrelated to this change and worth fixing separately:
go.modnow requires Go 1.26.7 (commit 40a6621) but the system Go here is 1.26.5, andgocannot download the toolchain because IPv6 egress gets403 Forbiddenfromproxy.golang.org(IPv4 returns 200). Nothing in this checkout builds with the default toolchain as a result. I fetched 1.26.7 over IPv4 into/tmpto run the checks and deleted it afterwards; no system state was changed.Go Report Card has been sunset, so the badge no longer reports anything. Removed it from the README, and also removed the CLAUDE.md section instructing that the project hold an A+ grade there, since that instruction can no longer be acted on. The checks it named are already covered by the CI section above it: gofmt, gocyclo, ineffassign and misspell are listed there directly, and
go vetruns as golangci-lint's defaultgovetlinter. No code changed.