Repository navigation
docs: fix AppWorld domain and use VAKRA naming in READMEs - #210
Conversation
- AppWorld: replace "web automation" with Multi-App Personal Assistance (everyday consumer apps with multi-app personal tasks via APIs) - Refer to the M3 benchmark as VAKRA / M3 (headings, tables) or VAKRA (prose); keep `m3` in paths, scripts, and CLI flags - Update the VAKRA description to match upstream (multi-hop, multi-source tool calling over 8,000+ APIs across 62 domains) Closes #209 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Sergey Zeltyn <sergeyz@il.ibm.com>
haroldship
left a comment
There was a problem hiding this comment.
Review of PR #210
Verdict: Approve. Some small fixes are recommended, but none of them are mandatory.
What is correct
- The PR does not change any
m3identifier. Paths, script names, CLI flags, environment variables and--benchmark m3values all stay the same. - The PR renames three headings. No link in the repository points to these headings, so no link breaks.
- The VAKRA data agrees with
vendor/vakra/README.md: 8,000+ APIs, real databases, 62 domains and domain-aligned documents. - The domain label "API & Knowledge Retrieval" agrees with the VAKRA name.
- The AppWorld text is correct. The harness calls app APIs. It does not control a web browser.
- The tables keep 3 columns, so they render correctly.
- The PR has no unrelated changes.
Fixes (recommended)
PROJECT_OVERVIEW.md:40: The heading is "AppWorld (Web Automation)". This is the error that #209 tells about. If this PR does not fix it, #209 closes and the error stays in the repository. Change the heading to "AppWorld (Multi-App Personal Assistance)".benchmarks/appworld/README.md:78: The text says "(BPO, M3, Oak)". The PR changes this file, but it does not change this name. The root README uses "BPO/Oak/VAKRA". Change "M3" to "VAKRA".benchmarks/m3/README.md:1: The heading has a hockey emoji (🏒). The PR removes the "hockey domain" description everywhere else. The emoji tells readers that the benchmark is about hockey. Remove the emoji, or use a neutral emoji.benchmarks/m3/README.md:103: The text says "can span hundreds of domains". Line 5 says "62 domains". A reader can think that these two numbers do not agree. Change the text to "can span many domains".README.md:109andbenchmarks/m3/README.md:5: The two scope notes are different.README.md:109gives only the folder, the scripts and the--benchmarkvalue.benchmarks/m3/README.md:5also gives the CLI flags. Use the same text in the two files.
Follow-up (for a new issue)
These documents also have old text. This PR does not need to fix them.
PROJECT_OVERVIEW.md:4says "web automation".PROJECT_OVERVIEW.md:35-37says "Hockey statistics domain" and "211 API endpoints".benchmarks/m3/CONTAINER_SETUP.mdandCONTRIBUTING.md:48use "M3" in the text. This is not incorrect, but it is not the same as the new READMEs.
| @@ -1,8 +1,8 @@ | |||
| # 🏒 M3 Benchmark | |||
| # 🏒 VAKRA / M3 Benchmark | |||
There was a problem hiding this comment.
The heading has a hockey emoji (🏒). The PR removes the "hockey domain" description everywhere else. The emoji tells readers that the benchmark is about hockey. Remove the emoji, or use a neutral emoji.
There was a problem hiding this comment.
Fixed in c49f65d: replaced 🏒 with 🔷, the emoji used by the upstream VAKRA README.
| ## 📊 Overview | ||
|
|
||
| The M3 benchmark evaluates multi-hop question answering capabilities across multiple domains. It tests the agent's ability to: | ||
| The [VAKRA](https://github.com/IBM/vakra) benchmark (named `m3` in this repo's folders, scripts and CLI flags) evaluates multi-hop, multi-source tool calling: agents answer questions using 8,000+ locally hosted APIs backed by real databases across 62 domains, plus domain-aligned document collections. It tests the agent's ability to: |
There was a problem hiding this comment.
This scope note gives the folders, the scripts and the CLI flags. The note in README.md:109 gives only the folder, the scripts and the --benchmark value. Use the same text in the two files.
There was a problem hiding this comment.
Fixed in c49f65d: both files now use the same note — folders, scripts and CLI values (e.g. --benchmark m3, --m3-data) use the name m3.
| ### Named experiments, resume & background | ||
|
|
||
| M3 config-mode runs can span hundreds of domains — use named experiments to survive crashes and long runtimes. Resume skips successfully completed `(task, domain)` pairs; failed domains are re-attempted. | ||
| VAKRA config-mode runs can span hundreds of domains — use named experiments to survive crashes and long runtimes. Resume skips successfully completed `(task, domain)` pairs; failed domains are re-attempted. |
There was a problem hiding this comment.
The text says "can span hundreds of domains". Line 5 says "62 domains". A reader can think that these two numbers do not agree. Change the text to "can span many domains".
There was a problem hiding this comment.
Fixed in c49f65d: now "can span many domains across capabilities". VAKRA has 62 distinct domains; config-mode runs are per (capability, domain) file, which is where the larger count came from.
| #### VAKRA / M3 Setup | ||
|
|
||
| If you plan to run the M3 benchmark: | ||
| If you plan to run the VAKRA benchmark (folder, scripts and `--benchmark` value use the name `m3`): |
There was a problem hiding this comment.
This scope note gives only the folder, the scripts and the --benchmark value. The note in benchmarks/m3/README.md:5 also gives the CLI flags. Use the same text in the two files.
There was a problem hiding this comment.
Fixed in c49f65d: both files now use the same note — folders, scripts and CLI values (e.g. --benchmark m3, --m3-data) use the name m3.
- PROJECT_OVERVIEW: AppWorld is Multi-App Personal Assistance, not web automation; use VAKRA naming for the M3 benchmark - AppWorld README and CONTRIBUTING: M3 -> VAKRA in prose - M3 README: neutral heading emoji; "many domains across capabilities" instead of "hundreds of domains" - Use the same `m3` naming note in README and the M3 README Refs #209 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Sergey Zeltyn <sergeyz@il.ibm.com>
|
Thanks for the review. Pushed c49f65d with all five suggestions:
Also changed |
Documentation Pull Request
Related Issue
Closes #209
Description
Corrects the AppWorld domain (it is not web automation) and refers to the M3 benchmark by its proper name, VAKRA, across the READMEs.
m3is kept wherever it is a folder, script, file name or CLI flag.Type of Changes
Changes Made
benchmarks/appworld/README.mdoverview): domain is now Multi-App Personal Assistance; description is "Everyday consumer apps (email, shopping, payments, music) with multi-app personal tasks via APIs".benchmarks/m3/README.md): headings and tables say VAKRA / M3, prose says VAKRA; added a note that folders, scripts and the--benchmarkvalue still usem3. Paths, flags and identifiers (benchmarks/m3/,setup_m3.sh,--m3-data,eval_m3.py,vendor/vakra) are unchanged.Verification
Checklist
🤖 Generated with Claude Code
Summary by CodeRabbit