Skip to content

session-agent#416

Merged
rogelioLpz merged 7 commits into
mainfrom
session-agent
Jun 30, 2026
Merged

session-agent#416
rogelioLpz merged 7 commits into
mainfrom
session-agent

Conversation

@rogelioLpz

@rogelioLpz rogelioLpz commented Jun 24, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features

    • Added support for agent sessions, including a new session type value for agents.
    • Introduced a new agent request format with required pairing code and phone number, plus optional device details.
    • Added agent query filtering via an optional active flag.
    • Exposed the new agent-related request and query types at the main package level.
  • Chores

    • Updated the package version to 2.1.39.

@rogelioLpz rogelioLpz requested a review from gmorales96 June 24, 2026 15:46
@rogelioLpz rogelioLpz self-assigned this Jun 24, 2026
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 909e9555-e8b3-48f0-abf1-3a98ed4506ad

📥 Commits

Reviewing files that changed from the base of the PR and between 7f1b9d7 and a2e6ad5.

📒 Files selected for processing (1)
  • cuenca_validations/version.py
✅ Files skipped from review due to trivial changes (1)
  • cuenca_validations/version.py

Walkthrough

Adds SessionType.agent, new AgentQuery and AgentRequest models, package-level re-exports for both types, and updates cuenca_validations/version.py to 2.1.39.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested reviewers

  • felipao-mx
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is related to the changes, but it is too terse and reads like a branch name rather than a clear summary. Rename it to a descriptive summary, such as "Add agent session request and query types".
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch session-agent

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (62957a5) to head (a2e6ad5).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #416   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines         1502      1510    +8     
=========================================
+ Hits          1502      1510    +8     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cuenca_validations/types/__init__.py 100.00% <ø> (ø)
cuenca_validations/types/enums.py 100.00% <100.00%> (ø)
cuenca_validations/types/queries.py 100.00% <100.00%> (ø)
cuenca_validations/types/requests.py 100.00% <100.00%> (ø)
cuenca_validations/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 62957a5...a2e6ad5. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@cuenca_validations/types/queries.py`:
- Around line 196-197: The AgentQuery public query field rename is breaking
downstream callers because the exported query model no longer accepts the old
contract. Update AgentQuery in queries.py to preserve compatibility by keeping
the existing status field as a deprecated alias or by supporting both status and
active in the model, and ensure any validation/mapping logic in AgentQuery or
QueryParams translates the legacy field to the new one without breaking existing
consumers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: db59d464-8c63-476b-8b8e-0be088850a54

📥 Commits

Reviewing files that changed from the base of the PR and between 5327c9b and 7f1b9d7.

📒 Files selected for processing (4)
  • cuenca_validations/types/__init__.py
  • cuenca_validations/types/enums.py
  • cuenca_validations/types/queries.py
  • cuenca_validations/version.py
💤 Files with no reviewable changes (2)
  • cuenca_validations/types/enums.py
  • cuenca_validations/types/init.py
✅ Files skipped from review due to trivial changes (1)
  • cuenca_validations/version.py

Comment thread cuenca_validations/types/queries.py
@rogelioLpz rogelioLpz merged commit e5b3765 into main Jun 30, 2026
21 checks passed
@rogelioLpz rogelioLpz deleted the session-agent branch June 30, 2026 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants