Skip to content

Resources Agents#442

Merged
rogelioLpz merged 5 commits into
mainfrom
agents
Jun 30, 2026
Merged

Resources Agents#442
rogelioLpz merged 5 commits into
mainfrom
agents

Conversation

@rogelioLpz

@rogelioLpz rogelioLpz commented Jun 27, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • New Features
    • Added new Agent and AgentVerification resources, including create support for agent verification and agent creation.
    • Exposed these resources for direct use and included them in the package’s resource registry.
  • Bug Fixes
    • Improved agent creation to gracefully handle omitted optional device information.
  • Tests
    • Added a VCR-backed integration test (with a recorded HTTP cassette) covering agent creation.
  • Chores
    • Bumped the package version and updated the pinned validation dependency.

@rogelioLpz rogelioLpz requested a review from gmorales96 June 27, 2026 02:02
@rogelioLpz rogelioLpz self-assigned this Jun 27, 2026
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 90c5bd0b-e70d-4bb8-8274-77574f267e02

📥 Commits

Reviewing files that changed from the base of the PR and between e014251 and 520328f.

📒 Files selected for processing (1)
  • requirements.txt
🚧 Files skipped from review as they are similar to previous changes (1)
  • requirements.txt

Walkthrough

Adds Agent and AgentVerification resource models with typed fields, schema examples, and create methods. Both are exported from the resource package and top-level package, registered in the resource registry, and covered by a VCR-backed integration test. The package version is bumped to 2.2.2, and cuenca-validations is pinned to 2.1.39.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • alexviquez
  • gmorales96
🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title is related to the new resources, but it is too vague and generic to clearly describe the main change. Use a more specific title such as 'Add Agent and AgentVerification resources'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agents

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Jun 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (eef879c) to head (520328f).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #442   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           55        57    +2     
  Lines         1227      1269   +42     
=========================================
+ Hits          1227      1269   +42     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cuenca/__init__.py 100.00% <ø> (ø)
cuenca/resources/__init__.py 100.00% <100.00%> (ø)
cuenca/resources/agent_verifications.py 100.00% <100.00%> (ø)
cuenca/resources/agents.py 100.00% <100.00%> (ø)
cuenca/version.py 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef879c...520328f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@tests/resources/test_agents.py`:
- Around line 6-8: The top-level test function in test_agent_create violates
flake8 spacing rules, causing CI to fail. In the test_agents.py snippet, ensure
there are two blank lines before the top-level function definition and update
the inline comment on the AgentVerification.create() line to have at least two
spaces before the comment marker. Use the existing test_agent_create function
and AgentVerification.create() call as the locations to fix.
- Around line 8-10: The verification setup is using the ambient global session
instead of the sandbox-configured Session, so the first VCR interaction can miss
the intended base URL/headers. Update the test setup around
AgentVerification.create() and agent_session.configure(sandbox=True) so the
configured sandbox session is passed into AgentVerification.create(), matching
the session used for Agent.create() and keeping the verification flow
consistent.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5fe40a1e-d4e7-46bf-9e56-d6941f8b8270

📥 Commits

Reviewing files that changed from the base of the PR and between 7088099 and 70d779b.

📒 Files selected for processing (2)
  • tests/resources/cassettes/test_agent_create.yaml
  • tests/resources/test_agents.py
✅ Files skipped from review due to trivial changes (1)
  • tests/resources/cassettes/test_agent_create.yaml

Comment thread tests/resources/test_agents.py Outdated
Comment thread tests/resources/test_agents.py Outdated
@rogelioLpz rogelioLpz enabled auto-merge (squash) June 30, 2026 18:13
@rogelioLpz rogelioLpz disabled auto-merge June 30, 2026 18:20
@rogelioLpz rogelioLpz merged commit bef3fec into main Jun 30, 2026
18 checks passed
@rogelioLpz rogelioLpz deleted the agents branch June 30, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant