test(time): use fake timers instead of real setTimeout waits - #2923
Open
nikolauspschuetz wants to merge 1 commit into
Open
nikolauspschuetz wants to merge 1 commit into
nikolauspschuetz wants to merge 1 commit into
Conversation
The wrapPromiseWithTimeout specs raced real setTimeout timers — an inner promise resolving at 50/10ms against a 25ms timeout — so the "does not time out" case (10ms vs 25ms) is a latent flake: under CI load the event loop can fire the 25ms timeout before the 10ms resolve and reject a promise that was supposed to succeed. Drive the timers with @sinonjs/fake-timers via FakeTimers.withGlobal(timeMethods) — the same pattern used in stopwatch_spec.ts, test_case_runner_spec.ts and assemble_test_cases_spec.ts, and wrapPromiseWithTimeout schedules its timeout through the shared ../time methods object, so faking that object controls it. The clock is advanced with clock.tick(...), making the outcome of each race deterministic regardless of real-world scheduling. Behaviour and assertions are unchanged; the file no longer waits on the wall clock. Signed-off-by: Nikolaus Schuetz <nikolauspschuetz@gmail.com>
nikolauspschuetz
marked this pull request as ready for review
September 3, 2026 19:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
time_spec.tsdrovewrapPromiseWithTimeout()with realsetTimeouttimers, so the "does not time out" case raced a 10ms resolve against a 25ms timeout. Switched to@sinonjs/fake-timers, same as #2874.⚡️ What's your motivation?
That 10ms-vs-25ms case can flake under CI load.
🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.