Replace unmaintained dagre with @dagrejs/dagre#387
Closed
blaipr wants to merge 1 commit into
Closed
Conversation
This was referenced Jun 10, 2026
dagre 0.8.5 (2018) is unmaintained; @dagrejs/dagre is the maintained continuation by the same project organization. The workflow visualizer is the only consumer and uses exactly two APIs (graphlib.Graph and layout), both unchanged in the fork. Differences absorbed: - the layout now leaves internal rank/order metadata on node objects, and sibling order within a rank (which parallel branch renders on top) is decided differently - both arbitrary, so the WorkflowUtils layout test now asserts geometry without library internals - licenses/ui: dagre.txt -> dagrejs-dagre.txt (same MIT license, same original copyright)
blaipr
force-pushed
the
feature/dagrejs-dagre
branch
from
531a5cb to
e896f99
Compare
Contributor
Author
|
Superseded by #391, which combines this PR with the other two package-lock-regenerating toolchain upgrades (#377/#378/#387). The three were mutually conflicting on the lockfile (npm inserts their entries at the same alphabetical positions), so combining them is what makes the whole queue mergeable in any order. Content and verification are unchanged — see #391. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Suggested merge order for all 15 open PRs
Same list on every PR. Hard requirement: #381 before #382/#383/#384. Per-PR rebase/conflict notes are below the list.
package-lock.json; whichever merges after another needs a trivialnpm installregen.src/components/Workflow/WorkflowUtils.js: Upgrade ESLint from 8 to 9 with flat config #378 rewrites the eslint-disable comment on line 1, this PR rewrites the dagre import on line 3. If git flags it, keep both changes.SUMMARY
dagre0.8.5 (last release 2018, unmaintained) →@dagrejs/dagre3.0.0, the maintained continuation by the same project organization. The workflow visualizer is the only consumer, via exactly two APIs —dagre.graphlib.Graphanddagre.layout— both unchanged in the fork, so the swap is one import line.Two cosmetic differences absorbed:
rank/ordermetadata on the node objects, and sibling order within a rank (which parallel branch renders on top in the visualizer) is decided differently — both arbitrary layout details, so theWorkflowUtilslayout test now asserts geometry (x/y/width/height) without coupling to library internalslicenses/ui:dagre.txt→dagrejs-dagre.txt(same MIT text, same original copyright)This closes the last 'no newer release exists' item from the dependency audit.
Independent of all open PRs (same
package-lock.jsonregen caveat as the other UI PRs).ISSUE TYPE
COMPONENT NAME
ASCENDER VERSION
ADDITIONAL INFORMATION