Fix/standardize advisor terminology 1618

[MILAN-123865]

Pull Request

Description

Please provide a brief summary of your changes.

---

Related Issue

Closes #

---

Scope

This PR touches exactly one of the following. If it touches more than
one, split it into separate PRs — multi-scope PRs are the pattern that
introduces inconsistent architecture and will not be reviewed as-is.

• Cipher module (lib/cipher/**)
• Visualizer/route (app/**, components/**)
• Worker/protocol (lib/workers/**, hooks/use*Worker.ts)
• Documentation only (docs/**, *.md, MDX content)
• Security fix (CSP, key handling, sanitization, dependency CVE)
• Test-only (tests/**)
• Config/chore (build, deps, CI)

---

Changes Made

---

Testing

• Unit tests added/updated for every code path changed (not just the happy path).
• npm test passes locally.
• npm run typecheck passes locally.
• npm run lint passes locally.
• Coverage on any touched lib/cipher/** file stays at or above 80%.
• E2E/a11y tests added if a route or interactive component changed.

A PR that adds functionality without a corresponding test in the same PR will not be merged. "Will add tests later" is not accepted.

Simulation vs. Live Data

• I have read the Simulation vs. Live Data Policy: docs/simulation-vs-live-data-policy.md
• This change does not describe, label, or imply that a simulated operation (reduced parameters, mocked peer, synthetic randomness) is a verified or real cryptographic operation, in code, UI copy, or this PR description.

---

Screenshots

If applicable, attach screenshots or screen recordings.

---

Checklist

• My code follows the project guidelines.
• I have tested my changes.
• I have updated the documentation if required.
• My changes address the related issue.
• This PR focuses on a single issue.

---

Applicable Checklist

Complete the checklist matching the scope above, then paste the completed
checklist (or a link to it) here:

• New cipher -> Cipher Checklist: docs/contribution-checklists.md#1-new-cipher-checklist
• New visualizer -> Visualizer Checklist: docs/contribution-checklists.md#2-new-visualizer-checklist
• Security-sensitive -> Security Checklist: docs/contribution-checklists.md#3-security-sensitive-feature-checklist

---

Architecture Review Checklist

Before adding another domain suite or feature suite, please identify and document the following to prevent code duplication:

• Existing shared abstractions:
• Existing persistence mechanism:
• Existing operation state machine:
• Existing authorization boundary:
• Existing error model:
• Existing telemetry/audit mechanism:

Additional Notes

Add any additional information for reviewers here.

Description

This PR addresses fragmented application taxonomy by standardizing all algorithm selection and recommendation tools to use the canonical term Advisor. This brings the UI into strict alignment with Section 1 of docs/product-vocabulary-architecture.md.

Changes

• app/advisor/page.tsx: Updated template parameters to feature Algorithm Advisor (title/breadcrumbs) and Decision Support System (eyebrow).
• app/security-recommendation/page.tsx: Replaced "Engine" references with Security Architecture Advisor (title), Cryptographic Migration Advisor (eyebrow), and Security Advisor (breadcrumbs).
• components/layout/footer.tsx & lib/layout/navigation.ts: Verified layout boundaries to enforce uniform, predictable routing labels.

Verification Results

• Audited route templates to confirm that "Recommendation Assistant" and "Recommendation Engine" are completely removed from headers, subheadings, and breadcrumbs.
• Confirmed compliance with WCAG 2.4.6 by removing the cognitive friction between layout navigation actions and destination headers.

Closes #1618

[vercel]

@MILAN-123865 is attempting to deploy a commit to the csxark's projects Team on Vercel.

A member of the Team first needs to authorize it.

[github-actions]

🎉 Thank You for Your Contribution

Hello @MILAN-123865,

Thank you for submitting a Pull Request to CryptoViz. We appreciate the time and effort you've invested in contributing to the project.

Your Pull Request has been received successfully and will be reviewed by the maintainers as soon as possible.

📋 Pull Request Checklist

• ✅ Linked the related issue
• ✅ No merge conflicts
• ✅ Synced with the latest main branch
• ✅ Build passes successfully
• ✅ All tests pass

Ensuring these requirements are met helps streamline the review process and enables maintainers to review your contribution more efficiently.

❤️ Support CryptoViz

If you find CryptoViz helpful, consider supporting the project by:

• ⭐ Starring the repository
• 🍴 Forking the repository
• 👤 Following Ark on GitHub
• 💼 Connecting on LinkedIn
• 🌐 Visiting the Portfolio

Your support helps increase the project's visibility and encourages continued development. Thank you for being a part of the CryptoViz community!

Thank you once again for contributing to CryptoViz. We appreciate your support and look forward to reviewing your contribution.

[coderabbitai]

Warning

Review limit reached

Next included review available in 59 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: dd73a64d-c948-4e25-a0d8-d78a7c59ea9b

📥 Commits

Reviewing files that changed from the base of the PR and between e7ddcb9 and 127737f.

📒 Files selected for processing (18)

• README.md
• app/advisor/page.tsx
• app/page.tsx
• app/security-recommendation/page.tsx
• components/avalanche/AvalancheVisualizer.tsx
• docs/rc6-correctness.md
• eslint.config.mjs
• hooks/useCryptoSonifier.ts
• lib/cipher/asymmetric/saber.ts
• lib/cipher/registry.ts
• lib/cipher/symmetric/simon.ts
• lib/i18n/locales/en.ts
• lib/resources/cryptographyVideoLibrary.ts
• tests/unit/accessibility/sonifier.test.ts
• tests/unit/asymmetric/ecdsa.test.ts
• tests/unit/protocols/srp6a.test.ts
• tests/unit/random/hmacDrbg.test.ts
• tests/unit/utils/citationRegistry.test.ts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🎉 Pull Request Merged

Hello @MILAN-123865,

Thank you for your contribution to CryptoViz. Your Pull Request has been reviewed and successfully merged into the project.

We sincerely appreciate the time and effort you invested in improving the project. Contributions like yours help make CryptoViz better for the entire community.

We look forward to your future contributions and hope to collaborate with you again.

❤️ Support CryptoViz

If you find CryptoViz helpful, consider supporting the project by:

• ⭐ Starring the repository
• 🍴 Forking the repository
• 👤 Following Ark on GitHub
• 💼 Connecting on LinkedIn
• 🌐 Visiting the Portfolio

Your support helps increase the project's visibility and encourages continued development. Thank you for being a part of the CryptoViz community!