-
Notifications
You must be signed in to change notification settings - Fork 2
Serve fonts using css-helper instead of javascript #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d4b50e7
refractor to use css for serving fonts
lodewiges 9eba404
load all font files
lodewiges afb1d8f
Remove turbo from login button
lodewiges 54e3059
code rabbit sugestions
lodewiges 9a98f5e
move fonts to public folder
lodewiges 5afd39a
small bug fixes
lodewiges 3ba4c8b
fix typos in readme
lodewiges 5de1da8
fix lint
lodewiges File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #!/usr/bin/env ruby | ||
| # Copies FontAwesome font files from node_modules to public/webfonts | ||
|
|
||
| require 'fileutils' | ||
|
|
||
| # Source and destination directories | ||
| source = File.expand_path('../node_modules/@fortawesome/fontawesome-free/webfonts', __dir__) | ||
| dest = File.expand_path('../public/webfonts', __dir__) | ||
|
|
||
| unless Dir.exist?(source) | ||
| abort "Source directory not found: #{source}\nDid you run 'yarn install' or 'npm install'?" | ||
| end | ||
|
|
||
| FileUtils.mkdir_p(dest) | ||
|
|
||
| # Copy all font files | ||
| font_exts = %w[.woff2 .woff .ttf .eot] | ||
| Dir.entries(source).each do |file| | ||
| next unless font_exts.include?(File.extname(file)) | ||
| FileUtils.cp(File.join(source, file), File.join(dest, file)) | ||
| puts "Copied #{file}" | ||
| end | ||
|
|
||
| puts "All FontAwesome fonts copied to #{dest}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing semicolon in CSS rule.
Line 85 is missing a semicolon after the
widthproperty, which is a critical syntax error that will cause CSS parsing to fail..btn-login { - width: 100% + width: 100%; }📝 Committable suggestion
🤖 Prompt for AI Agents