Skip to content

Fix Float Rank hyperlinks for Souvenirs/StatTraks#405

Open
rxl211 wants to merge 2 commits into
csfloat:masterfrom
rxl211:master
Open

Fix Float Rank hyperlinks for Souvenirs/StatTraks#405
rxl211 wants to merge 2 commits into
csfloat:masterfrom
rxl211:master

Conversation

@rxl211

@rxl211 rxl211 commented Jun 29, 2026

Copy link
Copy Markdown

I noticed that on Steam inventories, when you selected a StatTrak or Souvenir item and it had a displayed float Rank, clicking on the link would always take you to the database with a category=1 (Normal) filter selected, even though the selected item was StatTrak/souvenir.

Example:
image

The root cause seemed to be that the itemInfo.full_item_name field was never populated, and so downstream code which looks at full_item_name to derive the correct category filter when constructing the hyperlink would always just default to category=1.

This PR includes a change to selected_item_info.ts to populate full_item_name inside of processSelectChange().

I verified this fixes the bug locally by loading the unpackaged extension in Chrome. I did not test on Firefox.


Note

Low Risk
Localized inventory UI change with no auth or data-model impact; main behavioral change is correct hyperlink category plus ignoring outdated fetch responses.

Overview
Fixes float rank hyperlinks for StatTrak and Souvenir items in the Steam inventory panel by setting itemInfo.full_item_name from the selected asset’s market_hash_name after the inspect fetch. renderClickableRank / getFloatDbCategory use that field to pick the DB category filter (Normal vs StatTrak vs Souvenir); without it, links always used category 1.

Also guards against stale async updates when the user changes selection while a float request is in flight (compare assetid before applying results) and tightens null checks around the fetch path.

Reviewed by Cursor Bugbot for commit 28c14a9. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 6f5342d. Configure here.

Comment thread src/lib/components/inventory/selected_item_info.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant