Fix Float Rank hyperlinks for Souvenirs/StatTraks#405
Open
rxl211 wants to merge 2 commits into
Open
Conversation
…ouvenirs and StatTraks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6f5342d. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I noticed that on Steam inventories, when you selected a StatTrak or Souvenir item and it had a displayed float Rank, clicking on the link would always take you to the database with a category=1 (Normal) filter selected, even though the selected item was StatTrak/souvenir.
Example:

The root cause seemed to be that the itemInfo.full_item_name field was never populated, and so downstream code which looks at full_item_name to derive the correct category filter when constructing the hyperlink would always just default to category=1.
This PR includes a change to selected_item_info.ts to populate full_item_name inside of processSelectChange().
I verified this fixes the bug locally by loading the unpackaged extension in Chrome. I did not test on Firefox.
Note
Low Risk
Localized inventory UI change with no auth or data-model impact; main behavioral change is correct hyperlink category plus ignoring outdated fetch responses.
Overview
Fixes float rank hyperlinks for StatTrak and Souvenir items in the Steam inventory panel by setting
itemInfo.full_item_namefrom the selected asset’smarket_hash_nameafter the inspect fetch.renderClickableRank/getFloatDbCategoryuse that field to pick the DBcategoryfilter (Normal vs StatTrak vs Souvenir); without it, links always used category 1.Also guards against stale async updates when the user changes selection while a float request is in flight (compare
assetidbefore applying results) and tightens null checks around the fetch path.Reviewed by Cursor Bugbot for commit 28c14a9. Bugbot is set up for automated code reviews on this repo. Configure here.