fix(input): expose native editable accessibility by hyochan · Pull Request #16 · crossplatformkorea/cpk-ui

hyochan · 2026-09-05T18:32:16Z

Summary

Keep EditText discoverable as a native input instead of grouping it into the surrounding touch target. Border taps still focus the field. Add a regression test and an accessible email story.

Verification

Regression fails before the fix and passes afterward.
Full test:all: 23 suites, 304 tests; lint, type and story/component checks pass.
Package build passes; live web story accepts text through its accessible name.
Physical iPad mini: previously hidden TextField becomes discoverable, email + OTP login succeeds, authenticated calendar loads.
Full compiled patch applies to a pristine 0.8.0-beta.2 registry copy and EditText output matches the upstream build.
Android consumer replay pending; no release or complete screen-reader certification claimed.

Summary by CodeRabbit

Accessibility
- Improved EditText accessibility by ensuring screen readers and keyboard navigation target the text input directly.
- Preserved accessibility labels and email-specific keyboard behavior.
Documentation
- Added an accessible email input example to the component’s Storybook documentation.
Tests
- Added coverage verifying direct input accessibility and email keyboard configuration.

coderabbitai · 2026-09-05T18:33:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: 8388a520-2e6c-412b-84a7-1ad513df6451

📥 Commits

Reviewing files that changed from the base of the PR and between dc0c67d and 719ab9d.

📒 Files selected for processing (3)

src/components/uis/EditText/EditText.stories.tsx
src/components/uis/EditText/EditText.test.tsx
src/components/uis/EditText/EditText.tsx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

The EditText touch wrapper is excluded from accessibility traversal. Tests verify direct input access, label preservation, and email keyboard forwarding. A Storybook story documents the accessible email-input configuration.

Changes

EditText accessibility

Layer / File(s)	Summary
Expose the inner input as the accessibility target `src/components/uis/EditText/EditText.tsx`, `src/components/uis/EditText/EditText.test.tsx`, `src/components/uis/EditText/EditText.stories.tsx`	The touch wrapper sets `accessible={false}`. Tests verify direct labeled input access and email keyboard forwarding. The `AccessibleEmail` story documents the configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 719ab

EditText now exposes its native input directly to accessibility services while retaining border-tap focus behavior. The targeted regression coverage supports merge readiness with no active current-head risk identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: preserving native input accessibility in EditText.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch bugfix/edit-text-native-accessibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-09-05T18:33:47Z

Visit the preview URL for this PR (updated for commit 719ab9d):

https://cpk-ui--pr16-bugfix-edit-text-nat-stuwult9.web.app

_{(expires Sat, 12 Sep 2026 18:33:43 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 05244aa8e2a82af676f8a528c78a4bcd59756f99}

## Summary - Add a public PageIndicator driven directly by continuous UI-thread pager progress, with reversal, bounds, accessible state and reduced-motion support. - Include colocated stories and regressions. This branch includes the existing EditText accessibility fix from #16. - Prepare 0.8.0-beta.3 for the separately approved prerelease; this PR does not itself publish it. ## Verification - Full test:all: 24 suites, 310 tests passed; package build passed. - All seven e2e-smoke checks and static Storybook build passed. - Live browser partial progress and reversal yielded 14px then 7px; reduced motion remained at the settled page. No page errors. - Physical Android consumer captures confirm the pill between dots during both forward and reverse swipes, not only after settling. - Consumer integration regressions cover rapid Next, resize and reduced motion. Physical iOS verification remains pending; no iOS acceptance claim. Publication remains gated on the exact-head checks. No app data, credentials or private consumer sources are included.  ## Summary by CodeRabbit * **New Features** * Added a page indicator with animated progress, theming, customization, accessibility support, and reduced-motion behavior. * Added Storybook examples for continuous page transitions and reduced-motion settings. * **Accessibility** * Improved EditText accessibility by ensuring the editable field is directly discoverable while its touch wrapper remains excluded from accessibility navigation. * Added an accessible email input example with appropriate labeling and keyboard behavior. * **Tests** * Added coverage for page indicator behavior, accessibility, reduced motion, and EditText interactions.

fix(input): expose native editable accessibility

719ab9d

hyochan added ⌚ ux User Experience 🐛 bug Something isn't working labels Sep 5, 2026

hyochan mentioned this pull request Sep 6, 2026

feat(ui): add continuous page indicator #18

Merged

Navigation Menu

Uh oh!

fix(input): expose native editable accessibility - #16

fix(input): expose native editable accessibility#16
hyochan wants to merge 1 commit into
mainfrom
bugfix/edit-text-native-accessibility

hyochan commented Sep 5, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 5, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

hyochan commented Sep 5, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

github-actions Bot commented Sep 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

hyochan commented Sep 5, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 5, 2026 •

edited

Loading