Repository navigation
fix(projects): resolve IntegrationHarbor projectIdRef - #458
Open
henrysachs wants to merge 1 commit into
Open
henrysachs wants to merge 1 commit into
henrysachs wants to merge 1 commit into
Conversation
Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #446
Why
Project
IntegrationHarborhasprojectIdRefandprojectIdSelector, but noResolveReferences. A resource that set only the ref kept an emptyprojectId.What changed
IntegrationHarbor.ResolveReferencesinapis/namespaced/projects/v1alpha1/referencers.go. It matches the other project kinds, such asIntegrationMattermost.apis/cluster/projects/v1alpha1/zz_referencers.go).ResolveReferencesunit test with a mock reader, plus its generated cluster copy.Scope
Only
IntegrationHarborwas missing a resolver. Every other kind with*Reffields underapis/{namespaced,cluster}/{groups,projects,instance}has one. Some are hand-written inreferencers.go. Others are generated inzz_generated.resolvers.gofrom+crossplane:generate:referencemarkers:AccessToken,DeployKey,PipelineSchedule,ProjectShareGroup,ProtectedBranch,ProtectedEnvironment.I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Verification
go build ./...,go test ./apis/... ./pkg/{namespaced,cluster}/controller/projects/integrationharbor/..., andgolangci-lintonapis/{namespaced,cluster}/projectsall pass.go generate -tags generate ./apis/...leaves no diff.ResolveReferencesis undefined. With the fix it passes.IntegrationHarborthat set onlyprojectIdRef.projectIdresolved to the project ID (654778), and the resource became Ready and Synced.GET /projects/654778/integrations/harborreturnedactive: truewith the configured url, project_name, and username. After delete, the integration showedactive: falseand empty properties.