Repository navigation
fix(provider): show controller-runtime logs with --debug - #453
Open
henrysachs wants to merge 1 commit into
Open
henrysachs wants to merge 1 commit into
henrysachs wants to merge 1 commit into
Conversation
Signed-off-by: Henry Sachs <henry.sachs@deutschebahn.com>
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
--debugshould give controller-runtime a real logger, but its logs never appear.mainsets a discard logger first and the debug logger second. controller-runtime keeps only the firstSetLoggercall, so the discard logger always wins. This has been the case since v0.9.0.What changed
maincallsctrl.SetLoggeronce. It passes the debug logger with--debugand the discard logger otherwise.Scope
--debugnothing changes. controller-runtime still gets the discard logger.Blast Radius
Only
--debugoutput changes. It now includes controller-runtime lines, such as controller start-up, and errors logged through the manager logger, such as gated controller setup failures.Verification
--debug, master printed no controller-runtime lines. This branch printed 81 "Starting Controller" and 83 "Starting EventSource" lines. Without--debug, both printed nothing.--debug, this branch also printed a gate setup error that master hides: "controller with name providerconfig/providerconfig.gitlab.m.crossplane.io already exists". fix(config): register ClusterProviderConfig controller on SafeStart #452 fixes that error.go build ./...,go test ./pkg/... ./cmd/...,golangci-lint run ./..., andgo generate -tags generate ./apis/... ./pkg/...(no diff) pass.I have:
make reviewable testto ensure this PR is ready for review. I ran the checks above instead.