Repository navigation
Mark the package as free of side effects - #538
Merged
Merged
Conversation
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks the package as free of side effects, so bundlers can drop modules that aren't used.
Without it, importing anything pulls in its whole dependency chain. For example, a plug-integrations plugin that only imports a constant ended up with ~3.5 KB of unused SDK modules (
apiKey,help,constants).I checked that no module relies on running code when imported: there are only class and schema definitions, and plug's
GlobalPlug.GLOBALsingleton just creates a promise. Nothing downstream does side-effect-only imports likeimport '@croct/...'. Simulating the flag in plug-integrations gave identical bundles for everything else and the expected reduction for the Shopify plugin.