Repository navigation
tests: run the brigade skill's ticket add and fire lines against the tool - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new test runs the
ticket addandfirecommand lines the brigade skill shows, so an example cannot drift from whatbrigade.pyaccepts without the suite failing.tests/test_skill_commands.pyreadst3/added/brigade/SKILL.md, fills each placeholder in the alternative it runs, and runs every line against a scratch store. A line the tool refuses fails the test and names the line number in the skill.docs/guide.mdnow namesedits.tsvamong the tablesopenwrites.Known limits. The scanner reads physical lines and does not follow a continued shell command. A bare command mention with no flags is skipped. Only the five-kind choice runs every alternative; other choices run their first. Tilde fences are not recognized.
Reviewed at 52c106e5.