Repository navigation
ketchup: name T3's preview and page tools for before and after visuals - #185
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The catch-up skill, ketchup, now says which T3 tools make its before and after visuals.
Upstream's text is kept word for word. Five sentences are added beside it, inside the two passages upstream added in 0.15.18.
preview_snapshoton a preview tab that is already open.preview_recording_startthenpreview_recording_stopon that same tab.preview_open, which keeps upstream's rule against starting an app to make a visual.html_previewand published withhtml_render, with a link to the runtime's Visual reports section.Known limits. The text does not say how to embed the saved screenshot, how many captures a before and after needs, or what to do when no tab is open beyond upstream's own "say plainly that none exists". Ketchup is now an override, so it is ported again each time upstream edits it.
Reviewed at b2379224.