FIX: Deadlock caused by fork in multiprocess - #571
Open
scranford1 wants to merge 3 commits into
Open
scranford1 wants to merge 3 commits into
scranford1 wants to merge 3 commits into
Conversation
Contributor
Author
|
@mpu-creare Curious to get your opinion on this. In unit testing, we hit deadlocking in |
Contributor
|
Frankly, we never use this functionality so I'd vote for simplifying by just deprecating this. |
Contributor
Author
I have deprecated the Process node and skipped related unit tests. |
scranford1
marked this pull request as ready for review
September 24, 2026 16:28
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The use of
forkcan lead to deadlocking in child processes due to how the parent process is cloned. By swapping tospawn, we remove the deadlock risk from the process. Usingspawn, introduces a significant performance hit and means that mutated global variables are no longer inherited as a new python interpreter is launched.