Skip to content

FIX: Use magic mock with root_marker - #569

Merged
scranford1 merged 1 commit into
developfrom
bugfix/zarr-compat-test
Sep 21, 2026
Merged

scranford1 merged 1 commit into
developfrom
bugfix/zarr-compat-test

Conversation

@scranford1

Copy link
Copy Markdown
Contributor

Fsspec's AsyncFileSystemWrapper reads root_marker via inspect.getaattr_static. This change ensures newer versions of rasterio using fsspec pass tests and do not raise AttributeError when get_s3_store tries to wrap the mock.

@scranford1
scranford1 requested a review from BAyotte September 21, 2026 16:16
@scranford1 scranford1 self-assigned this Sep 21, 2026
@scranford1
scranford1 force-pushed the bugfix/zarr-compat-test branch 2 times, most recently from 4408049 to c2e5502 Compare September 21, 2026 16:20
@sonarqubecloud

Copy link
Copy Markdown

@BAyotte BAyotte left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@scranford1
scranford1 merged commit eec6f81 into develop Sep 21, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants