Skip to content

Convert http to https where possible and labeled with NOSONAR when not - #33

Merged
jdw-creare merged 1 commit into
developfrom
feature/sq_https
Jun 9, 2026
Merged

jdw-creare merged 1 commit into
developfrom
feature/sq_https

Conversation

@jdw-creare

Copy link
Copy Markdown
Contributor

SonarQube flags http:// URLs as security hotspots, so we can do away with a number of them with code alterations.

@jdw-creare
jdw-creare requested a review from scranford1 June 8, 2026 22:45
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@scranford1 scranford1 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jdw-creare , looks good to me. I take it this is purposefully targeting main as a hotfix?

@jdw-creare

Copy link
Copy Markdown
Contributor Author

Thanks @jdw-creare , looks good to me. I take it this is purposefully targeting main as a hotfix?

Good catch, thanks! I had intended to target develop for some later release. I'll retarget and merge.

@jdw-creare
jdw-creare changed the base branch from main to develop June 9, 2026 13:10
@jdw-creare
jdw-creare merged commit f7540e5 into develop Jun 9, 2026
5 checks passed
@jdw-creare
jdw-creare deleted the feature/sq_https branch June 9, 2026 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants