Santizing error messages - #29
Merged
Merged
Conversation
|
jdw-creare
approved these changes
May 15, 2026
jdw-creare
left a comment
jdw-creare
left a comment
Contributor
There was a problem hiding this comment.
This is exactly how I would do it; thanks Blaine!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent potential data mining attacks we want to sanitize all error messages exposed to users to not contain any information about the application. While the current base does not appear to leak anything it shouldn't, these changes are in better practice with these guidelines and should help our code look better on potential security scans.