Skip to content

Feature/query formats - #16

Merged
scranford1 merged 12 commits into
developfrom
feature/query_formats
Mar 6, 2026
Merged

Feature/query formats#16
scranford1 merged 12 commits into
developfrom
feature/query_formats

Conversation

@scranford1

@scranford1 scranford1 commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Changes

  • Specify formats on a per query basis.
  • Improve instance vs non-instance collection handling.
  • Define resolution for only cube and area queries.
  • Ensure CoverageJSON outputs valid JSON values.
  • Find coordinates based on the largest length of dimensions in all coordinates.
  • Use WKT for Coordinate CRS.
  • Use generators to improve query performance.
  • Use X,Y,Z,T labels in CoverageJSON instead of Lon,Lat,Alt,Time.

@scranford1
scranford1 requested a review from jdw-creare March 2, 2026 14:58
@scranford1 scranford1 self-assigned this Mar 2, 2026
@scranford1
scranford1 marked this pull request as draft March 3, 2026 15:28
@scranford1
scranford1 force-pushed the feature/query_formats branch from f005503 to 8021bcf Compare March 3, 2026 16:11
@scranford1
scranford1 force-pushed the feature/query_formats branch from 8021bcf to c4264c8 Compare March 3, 2026 16:19
@scranford1
scranford1 force-pushed the feature/query_formats branch from 71c2d30 to 2b2356f Compare March 5, 2026 18:54
@scranford1
scranford1 force-pushed the feature/query_formats branch from 2b2356f to b4b2aaf Compare March 5, 2026 18:58
@scranford1
scranford1 marked this pull request as ready for review March 5, 2026 21:00
jdw-creare
jdw-creare reviewed Mar 6, 2026
View reviewed changes

@jdw-creare jdw-creare left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! If there's a way we can avoid adding the dependency on temporary files, that would be ideal, but if that's crazy complicated, I don't mind keeping them. How would you feel about spending some time trying out approaches without temporary files?

Comment thread ogc/podpac.py
Comment thread ogc/edr/edr_routes.py
Comment thread ogc/edr/edr_provider.py
Comment thread ogc/edr/edr_provider.py
@sonarqubecloud

sonarqubecloud Bot commented Mar 6, 2026

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@scranford1
scranford1 merged commit cf62944 into develop Mar 6, 2026
5 checks passed
@scranford1
scranford1 deleted the feature/query_formats branch March 10, 2026 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdw-creare jdw-creare jdw-creare approved these changes

Assignees

@scranford1 scranford1

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@scranford1 @jdw-creare