Skip to content

chore: exempt const-table files via rust-standards.toml, hoist tests-tree imports (§18, §6.1) - #23

Merged
vshengbro merged 1 commit into
masterfrom
chore/const-exempt-and-tests-mod-hoist
Oct 9, 2026
Merged

vshengbro merged 1 commit into
masterfrom
chore/const-exempt-and-tests-mod-hoist

Conversation

@vshengbro

Copy link
Copy Markdown
Member

Two 2026-10-09 rulings landed together (audit goes 51/51 with both):

  1. check 49 exemption — rust-standards.toml pub_const_exempt (repo-relative path globs, ** supported) lists the 11 constant-table files: the 9 behind check 49's 30 violations + stripe-pay-core protocol/const.rs and chunkify const.rs (same const-table shape; their items were in the unwired report). These crates are published on crates.io — depub would be a semver break, exemption is the configured route.
  2. check 26 tests-tree coverage — stripe-pay-server/client tests roots gain the crate glob (inner mod.rs drop their own), stripe-pay-core payment drops a redundant narrowed crate import, tcp/udp-request roots absorb the request_builder std blocks.

Gates: audit 51/51, clippy 0 warnings, cargo check --workspace --all-targets clean, fmt idempotent.

…tree imports (§18, §6.1)

Per the 2026-10-09 rulings:
- rust-standards.toml pub_const_exempt lists the 11 constant-table files
  (repo-relative path globs): the 9 files behind check 49's 30 violations
  plus stripe-pay-core protocol and chunkify const.rs, which are the same
  const-table shape (their constants were in the unwired report).
- check 26 now covers tests trees: stripe-pay-server/client roots gain the
  crate glob (inner mod.rs drop their own), stripe-pay-core payment drops
  the redundant narrowed crate import (the root glob already covers it),
  tcp/udp-request roots absorb the request_builder std blocks.

audit 51/51, clippy 0 warnings, cargo check --all-targets clean, fmt clean.
@ghfind-review ghfind-review Bot added the review: high ghfind author score; see https://ghfind.com label Oct 9, 2026
@vshengbro
vshengbro merged commit 08aa430 into master Oct 9, 2026
8 checks passed
@vshengbro
vshengbro deleted the chore/const-exempt-and-tests-mod-hoist branch October 9, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review: high ghfind author score; see https://ghfind.com

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant