Resolve 'cppcoreguidelines-pro-type-member-init' clang-tidy warnings

Author: glynos

.github/workflows/documentation.yml

@@ -43,6 +43,7 @@ jobs:
         run: |
           git clone https://github.com/Microsoft/vcpkg.git
           ./vcpkg/bootstrap-vcpkg.sh
+          vcpkg install nlohmann-json
 
       - name: Configure CMake
         run: |
@@ -51,6 +52,8 @@ jobs:
             -G Ninja \
             -DCMAKE_BUILD_TYPE=Release \
             -DCMAKE_TOOLCHAIN_FILE=${{ github.workspace }}/vcpkg/scripts/buildsystems/vcpkg.cmake \
+            -Dskyr_BUILD_TESTS=OFF \
+            -Dskyr_BUILD_DOCS=ON \
             .
 
       - name: Build documentation

include/skyr/containers/static_vector.hpp

@@ -20,7 +20,7 @@ namespace skyr {
 template <class T, std::size_t Capacity>
 class static_vector {
  private:
-  alignas(T) std::array<std::byte, sizeof(T) * Capacity> storage_;
+  alignas(T) std::array<std::byte, sizeof(T) * Capacity> storage_{};
   std::size_t size_ = 0;
 
   auto data_ptr() noexcept -> T* {

include/skyr/core/host.hpp

@@ -139,7 +139,7 @@ class host {
   }
 
  private:
-  host_types host_;
+  host_types host_{};
 };
 
 namespace details {

include/skyr/core/parse_query.hpp

@@ -15,8 +15,8 @@
 namespace skyr {
 ///
 struct query_parameter {
-  std::string name;
-  std::optional<std::string> value;
+  std::string name{};
+  std::optional<std::string> value{};
 
   /// Constructor
   query_parameter() = default;

include/skyr/core/url_parser_context.hpp

@@ -101,12 +101,12 @@ class url_parser_context {
  private:
   url_record url;
   url_parse_state state;
-  std::string_view input;
-  std::string_view::const_iterator input_it;
+  std::string_view input{};
+  std::string_view::const_iterator input_it{};
   bool* validation_error;
   const url_record* base;
-  std::optional<url_parse_state> state_override;
-  std::string buffer;
+  std::optional<url_parse_state> state_override{};
+  std::string buffer{};
 
   bool at_flag;
   bool square_braces_flag;

include/skyr/core/url_record.hpp

@@ -23,23 +23,23 @@ class url_record {
   using string_type = std::string;
 
   /// An ASCII string that identifies the type of URL
-  string_type scheme;
+  string_type scheme{};
   /// An ASCII string identifying a username
-  string_type username;
+  string_type username{};
   /// An ASCII string identifying a password
-  string_type password;
+  string_type password{};
   /// An optional URL host, either a domain, IPv4 or IPv6 address,
   /// an opaque host, or empty
-  std::optional<::skyr::host> host;
+  std::optional<::skyr::host> host{};
   /// An optional network port
-  std::optional<std::uint16_t> port;
+  std::optional<std::uint16_t> port{};
   /// A list of zero or more ASCII strings, used to identify a
   /// location in a hierarchical form
-  std::vector<string_type> path;
+  std::vector<string_type> path{};
   /// An optional ASCII string
-  std::optional<string_type> query;
+  std::optional<string_type> query{};
   /// An optional ASCII string
-  std::optional<string_type> fragment;
+  std::optional<string_type> fragment{};
 
   /// A Boolean value indicating whether this URL can be used as a
   /// base URL

include/skyr/domain/domain.hpp

@@ -65,21 +65,21 @@ constexpr auto validate_label(std::u32string_view label, [[maybe_unused]] bool u
 ///
 struct domain_to_ascii_context {
   /// Stores the domain as UTF-32
-  std::u32string domain_name;
+  std::u32string domain_name{};
 
   /// Parameters
-  std::string* ascii_domain;
-  bool check_hyphens;
-  bool check_bidi;
-  bool check_joiners;
-  bool use_std3_ascii_rules;
-  bool transitional_processing;
-  bool verify_dns_length;
+  std::string* ascii_domain{};
+  bool check_hyphens{};
+  bool check_bidi{};
+  bool check_joiners{};
+  bool use_std3_ascii_rules{};
+  bool transitional_processing{};
+  bool verify_dns_length{};
 
   // These are intermediate buffers
-  std::vector<std::u32string> labels;
-  std::string punycode_encoded;
-  std::u32string punycode_decoded;
+  std::vector<std::u32string> labels{};
+  std::string punycode_encoded{};
+  std::u32string punycode_decoded{};
 };
 
 ///
@@ -296,15 +296,15 @@ inline auto domain_to_ascii(std::string_view domain_name, std::string* ascii_dom
 }
 
 struct domain_to_u8_context {
-  std::string_view domain_name;
+  std::string_view domain_name{};
 
   /// Parameters
-  std::string* u8_domain;
+  std::string* u8_domain{};
 
-  std::vector<std::string> labels;
+  std::vector<std::string> labels{};
 
   /// This is used as an intermediate buffer
-  std::u32string punycode_decoded;
+  std::u32string punycode_decoded{};
 };
 
 ///

include/skyr/percent_encoding/percent_decode_range.hpp

@@ -118,7 +118,7 @@ class percent_decode_iterator {
     remainder_.remove_prefix(step);
   }
 
-  std::string_view remainder_;
+  std::string_view remainder_{};
 };
 
 ///

include/skyr/percent_encoding/percent_encoded_char.hpp

@@ -187,7 +187,7 @@ struct percent_encoded_char {
   }
 
  private:
-  impl_type impl_;
+  impl_type impl_{};
 };
 
 ///

include/skyr/unicode/ranges/transforms/u8_transform.hpp

@@ -205,7 +205,7 @@ class transform_u8_range {
   }
 
  private:
-  iterator_type first_;
+  iterator_type first_{};
 };
 
 ///