Fix first set of clang-tidy warnings

Author: glynos

.clang-tidy

@@ -5,6 +5,7 @@ Checks: >
   bugprone-*,
   -bugprone-exception-escape,
   -bugprone-easily-swappable-parameters,
+  -bugprone-branch-clone,
   clang-diagnostic-*,
   clang-analyzer-*,
   concurrency-*,
@@ -17,6 +18,7 @@ Checks: >
   -cppcoreguidelines-avoid-c-arrays,
   -cppcoreguidelines-avoid-do-while,
   -cppcoreguidelines-pro-type-reinterpret-cast,
+  -cppcoreguidelines-missing-std-forward,
   misc-*,
   -misc-unused-parameters,
   -misc-non-private-member-variables-in-classes,

.github/workflows/clang-tidy.yml

@@ -54,7 +54,7 @@ jobs:
       - name: Run clang-tidy on source files
         if: false  # Disabled for now
         run: |
-          find tests -name '*.cpp' -print0 | \
+          find examples -name '*.cpp' -print0 | \
             xargs -0 -n1 -P$(nproc) clang-tidy-21 -p build
 
       - name: clang-tidy check passed

include/skyr/core/check_input.hpp

@@ -16,15 +16,15 @@ constexpr static auto is_c0_control_or_space = [](auto byte) {
   return std::iscntrl(byte, std::locale::classic()) || std::isspace(byte, std::locale::classic());
 };
 
-constexpr inline auto remove_leading_c0_control_or_space(std::string_view input, bool* validation_error) {
+constexpr auto remove_leading_c0_control_or_space(std::string_view input, bool* validation_error) {
   auto first = std::cbegin(input), last = std::cend(input);
   auto it = std::find_if_not(first, last, is_c0_control_or_space);
   *validation_error |= (it != first);
   input.remove_prefix(std::distance(first, it));
   return input;
 }
 
-constexpr inline auto remove_trailing_c0_control_or_space(std::string_view input, bool* validation_error) {
+constexpr auto remove_trailing_c0_control_or_space(std::string_view input, bool* validation_error) {
   auto first = std::crbegin(input), last = std::crend(input);
   auto it = std::find_if_not(first, last, is_c0_control_or_space);
   *validation_error |= (it != first);

include/skyr/core/schemes.hpp

@@ -13,14 +13,14 @@
 namespace skyr {
 /// \param scheme
 /// \returns
-constexpr inline auto is_special(std::string_view scheme) noexcept -> bool {
+constexpr auto is_special(std::string_view scheme) noexcept -> bool {
   return (scheme == "file") || (scheme == "ftp") || (scheme == "http") || (scheme == "https") || (scheme == "ws") ||
          (scheme == "wss");
 }
 
 /// \param scheme
 /// \returns
-constexpr inline auto default_port(std::string_view scheme) noexcept -> std::optional<std::uint16_t> {
+constexpr auto default_port(std::string_view scheme) noexcept -> std::optional<std::uint16_t> {
   if (scheme == "ftp") {
     return 21;
   } else if ((scheme == "http") || (scheme == "ws")) {

include/skyr/core/url_parser_context.hpp

@@ -28,7 +28,7 @@ using namespace std::string_literals;
 using namespace std::string_view_literals;
 
 namespace details {
-constexpr inline auto contains(std::string_view view, char element) noexcept {
+constexpr auto contains(std::string_view view, char element) noexcept {
   auto first = std::cbegin(view), last = std::cend(view);
   return last != std::find(first, last, element);
 }
@@ -56,7 +56,7 @@ inline auto is_url_code_point(char byte) noexcept {
   return std::isalnum(byte, std::locale::classic()) || contains("!$&'()*+,-./:;=?@_~"sv, byte);
 }
 
-constexpr inline auto is_windows_drive_letter(std::string_view segment) noexcept {
+constexpr auto is_windows_drive_letter(std::string_view segment) noexcept {
   if (segment.size() < 2) {
     return false;
   }
@@ -74,11 +74,11 @@ constexpr inline auto is_windows_drive_letter(std::string_view segment) noexcept
   return result;
 }
 
-constexpr inline auto is_single_dot_path_segment(std::string_view segment) noexcept {
+constexpr auto is_single_dot_path_segment(std::string_view segment) noexcept {
   return (segment == ".") || (segment == "%2e") || (segment == "%2E");
 }
 
-constexpr inline auto is_double_dot_path_segment(std::string_view segment) noexcept {
+constexpr auto is_double_dot_path_segment(std::string_view segment) noexcept {
   return (segment == "..") || (segment == "%2e.") || (segment == ".%2e") || (segment == "%2e%2e") ||
          (segment == "%2E.") || (segment == ".%2E") || (segment == "%2E%2E") || (segment == "%2E%2e") ||
          (segment == "%2e%2E");

include/skyr/domain/domain.hpp

@@ -21,10 +21,9 @@
 #include <skyr/unicode/ranges/views/u8_view.hpp>
 
 namespace skyr {
-constexpr inline auto validate_label(std::u32string_view label, [[maybe_unused]] bool use_std3_ascii_rules,
-                                     bool check_hyphens, [[maybe_unused]] bool check_bidi,
-                                     [[maybe_unused]] bool check_joiners, bool transitional_processing)
-    -> std::expected<void, domain_errc> {
+constexpr auto validate_label(std::u32string_view label, [[maybe_unused]] bool use_std3_ascii_rules, bool check_hyphens,
+                              [[maybe_unused]] bool check_bidi, [[maybe_unused]] bool check_joiners,
+                              bool transitional_processing) -> std::expected<void, domain_errc> {
   /// https://www.unicode.org/reports/tr46/#Validity_Criteria;
 
   if (check_hyphens) {

include/skyr/domain/punycode.hpp

@@ -30,7 +30,7 @@ constexpr auto initial_n = 0x80ul;
 constexpr auto delimiter = 0x2dul;
 }  // namespace constants
 
-constexpr inline auto adapt(uint32_t delta, uint32_t numpoints, bool firsttime) -> std::uint32_t {
+constexpr auto adapt(uint32_t delta, uint32_t numpoints, bool firsttime) -> std::uint32_t {
   using namespace constants;
 
   delta = firsttime ? delta / damp : delta >> 1ul;
@@ -154,7 +154,7 @@ inline auto punycode_encode(std::u32string_view input, std::string* output) -> s
 /// \param output The output UTF-32 string to store the decoded result
 /// \returns The decoded UTF-8 domain, or an error
 template <class StringView>
-constexpr inline auto punycode_decode(StringView input, std::u32string* output) -> std::expected<void, domain_errc> {
+constexpr auto punycode_decode(StringView input, std::u32string* output) -> std::expected<void, domain_errc> {
   using namespace punycode::constants;
 
   // decode_digit(cp) returns the numeric value of a basic code

include/skyr/network/ipv4_address.hpp

@@ -81,11 +81,11 @@ class ipv4_address {
 
 namespace details {
 /// Computes 256^exp efficiently using bit shifts (256 = 2^8, so 256^n = 2^(8n))
-constexpr inline auto pow256(unsigned int exp) noexcept -> std::uint64_t {
+constexpr auto pow256(unsigned int exp) noexcept -> std::uint64_t {
   return 1ULL << (exp * 8);
 }
 
-constexpr inline auto parse_ipv4_number(std::string_view input, bool* validation_error)
+constexpr auto parse_ipv4_number(std::string_view input, bool* validation_error)
     -> std::expected<std::uint64_t, ipv4_address_errc> {
   auto base = 10;
 
@@ -116,7 +116,7 @@ constexpr inline auto parse_ipv4_number(std::string_view input, bool* validation
 /// \param input An input string
 /// \param validation_error Optional pointer to a bool that will be set if a validation error occurs
 /// \returns An `ipv4_address` object or an error
-constexpr inline auto parse_ipv4_address(std::string_view input, bool* validation_error)
+constexpr auto parse_ipv4_address(std::string_view input, bool* validation_error)
     -> std::expected<ipv4_address, ipv4_address_errc> {
   using namespace std::string_view_literals;
 

include/skyr/network/ipv6_address.hpp

@@ -145,7 +145,7 @@ class ipv6_address {
 
 namespace details {
 template <class intT, class charT>
-constexpr inline auto hex_to_dec(charT byte) noexcept {
+constexpr auto hex_to_dec(charT byte) noexcept {
   assert(std::isxdigit(byte, std::locale::classic()));
 
   if (std::isdigit(byte, std::locale::classic())) {
@@ -160,7 +160,7 @@ constexpr inline auto hex_to_dec(charT byte) noexcept {
 /// \param input An input string
 /// \param validation_error Optional pointer to a bool that will be set if a validation error occurs
 /// \returns An `ipv6_address` object or an error
-constexpr inline auto parse_ipv6_address(std::string_view input, bool* validation_error)
+constexpr auto parse_ipv6_address(std::string_view input, bool* validation_error)
     -> std::expected<ipv6_address, ipv6_address_errc> {
   using namespace std::string_view_literals;
 

include/skyr/percent_encoding/percent_decode_range.hpp

@@ -17,7 +17,7 @@
 namespace skyr {
 namespace percent_encoding {
 namespace details {
-constexpr inline auto alnum_to_hex(char value) noexcept -> std::expected<std::byte, percent_encode_errc> {
+constexpr auto alnum_to_hex(char value) noexcept -> std::expected<std::byte, percent_encode_errc> {
   if ((value >= '0') && (value <= '9')) {
     return static_cast<std::byte>(value - '0');
   }