test: add coverage for reap_nb() method - #298
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
reap_nb() is exported in @API but had zero test coverage. Add tests for: non-blocking behavior on running children, exit status collection, idempotent calling, and non-zero exit codes propagating through finish()/result().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
t/reap_nb.t— the first test coverage for thereap_nb()method.Why
reap_nb()is exported in@APIand documented in the POD, but had zerotest coverage. This is the only public API function in IPC::Run with no tests.
How
Ten tests covering:
reap_nbcalls are safe)finish()/result()/full_result()Testing
prove -Ilib t/reap_nb.t— 10/10 passmake test— all tests passQuality Report
Changes: 1 file changed, 112 insertions(+)
Code scan: clean
Tests: passed (OK)
Branch hygiene: clean
Generated by Kōan