fix: sync cpanfile and META_MERGE dependency versions - #294
Draft
toddr-bot wants to merge 2 commits into
Draft
Conversation
Makefile.PL was bumped to require IO::Pty 1.25 (commit 198fb75) to ensure compatibility with IO::Pty DESTROY changes, but cpanfile was not updated. Users installing via cpanfile would get 1.08, which is too old and triggers pty test failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Readonly::Array is a function in the Readonly package, not a standalone CPAN module. In Readonly 2.00+, there is no Readonly/Array.pm file at all. Replace with the correct module name 'Readonly'. Also sync Test::More version to '0.47' to match PREREQ_PM. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fix dependency version mismatches between cpanfile, Makefile.PL, and META_MERGE.
Why
Two packaging inconsistencies:
Readonly::Arrayas a build dependency, butReadonly::Arrayis a function in theReadonlypackage, not a standalone CPAN module. In Readonly 2.00+, there is noReadonly/Array.pmfile. The correct module name isReadonly.How
1.08→1.25Readonly::Array→Readonly, Test::More version synced to0.47Testing
make test: 863/863 pass (pty.t skips, pre-existing on this system)Readonly(notReadonly::Array)🤖 Generated with Claude Code