fix: remove stale REMOVE/ADD markers from Win32 modules - #290
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
Clean up annotations from an unfinished refactoring in Win32Helper.pm, Win32IO.pm, and Win32Pump.pm. The _inherit() function in Win32Helper had '#### REMOVE' on every line despite being actively used by Win32IO. The '#### ADD' blocks in Win32IO were commented-out alternative code that was never completed. Replace the misleading multi-line REMOVE comment in Win32IO with a concise explanation of why OS handles are used instead of fds. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove stale development annotations (
#### REMOVE,#### ADD,## REMOVE) from Win32Helper.pm, Win32IO.pm, and Win32Pump.pm.Why
These markers were left from an unfinished refactoring where the author wanted to switch from passing OS file handles to using fd-based save/restore around
CreateProcess. The alternative approach was never completed due to premature closure issues (documented in the original comment). The markers have been there for years and are misleading —_inherit()in Win32Helper.pm had#### REMOVEon every line despite being actively exported and used by Win32IO.pm.How
#### REMOVEmarkers from_inherit()and deleted the commented-out old version of the function (lines 93-100)#### ADDcode and 3## REMOVEmarkers. Replaced the 4-line explanatory comment with a concise 2-line note#### REMOVEmarkers from 13 lines of active codeNo functional changes — only annotations and dead comments removed.
Testing
make test: 863/863 pass (pty.t skips due to IO::Pty version, pre-existing)🤖 Generated with Claude Code
Quality Report
Changes: 3 files changed, 17 insertions(+), 58 deletions(-)
Code scan: clean
Tests: failed (0 Failed, 37 tests)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline