fix: declare MIN_PERL_VERSION and remove dead Perl 5.6 code - #289
Merged
toddr merged 1 commit intoApr 23, 2026
Merged
Conversation
Add MIN_PERL_VERSION => '5.008001' to Makefile.PL so CPAN clients can properly filter by Perl version and the xt/99_perl_minimum_version.t author test actually runs (it was silently skipping due to missing metadata). Remove the dead `$] < 5.008` code paths in Run.pm: the conditional `require Symbol` and the Symbol::gensym() workaround for a Perl 5.6.0 eval bug. These never executed since the minimum supported version is 5.008001. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Declare
MIN_PERL_VERSIONinMakefile.PLand remove dead Perl 5.6 workaround code fromRun.pm.Why
The
xt/99_perl_minimum_version.tauthor test was silently skipping in all environments — locally ("META.yml could not be found") and in CI ("no minimum perl version could be determined"). WithoutMIN_PERL_VERSION, the generated META.yml/META.json lack therequires.perlfield, so CPAN clients can't enforce version requirements.The
$] < 5.008code paths (conditionalrequire SymbolandSymbol::gensym()workaround for a Perl 5.6.0 eval bug) never execute since the minimum supported version is 5.008001.How
MIN_PERL_VERSION => '5.008001'with the standard EUMM version guard (>= 6.48)BEGIN { if ($] < 5.008) { require Symbol } }block_do_kid_and_exitTesting
make test: 863/863 pass (pty.t skips due to IO::Pty version, pre-existing)prove -Ilib xt/99_perl_minimum_version.t: now runs 57 checks (was 0) and passesMYMETA.ymlcontainsperl: '5.008001'in requires🤖 Generated with Claude Code