test: add comprehensive pipeline test coverage - #285
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
The '|' pipeline operator is core IPC::Run functionality but had only 2 test cases across the entire suite. Add 29 tests covering: - 2/3/4-stage pipelines - Per-child exit code inspection via results() - Per-child stderr capture - Async API (start/pump/finish) with pipelines - Pipeline timeout behavior - File descriptor leak detection across repeated runs - Empty input and binary data through pipelines Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add 29 tests for multi-child pipeline (
|) behavior in a newt/pipeline.t.Why
The pipeline operator is core IPC::Run functionality, yet the test suite had
only 2 pipeline test cases (one in
run.t, one inclose_stdin.t). This leftdata flow, exit code propagation, and resource cleanup across pipeline stages
essentially untested.
How
Tests cover:
results()andresult()exit code inspection per childstart/pump/finish) with streaming pipeline I/OTesting
All 29 new tests pass. Full suite: 892/892 subtests pass (existing
pty.tskip on systems with IO::Pty < 1.25 is unrelated).
🤖 Generated with Claude Code