fix: widen 'not too slow to reap' threshold in t/timeout.t - #283
Draft
toddr-bot wants to merge 1 commit into
Draft
fix: widen 'not too slow to reap' threshold in t/timeout.t#283toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
CPAN smokers (DCANTRELL, Perl 5.10-5.30, Linux) fail test 26 with 3-5 seconds elapsed. The original <= 2 threshold is too tight because: - time() has 1-second granularity (up to 1s measurement error) - sleep(1) takes longer on loaded smoker machines - The select() backoff loop adds 0.1-0.5s reaping latency Raise to <= 10. The test guards against hanging until the 180s timeout, not sub-second reaping performance. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Raise the timing threshold in t/timeout.t test 26 from
<= 2to<= 10seconds.Why
All three CPAN smoker failures for 20260402.0 are this single test (FAIL matrix):
The
<= 2threshold is too tight on loaded machines becausetime()has 1-second granularity (up to 1s measurement error),sleep(1)takes longer under CPU contention, and the select() backoff loop adds 0.1-0.5s of reaping latency.How
One-line change:
<= 2→<= 10. The test guards against hanging until the 180s timeout, not sub-second reaping performance. 10 seconds is generous enough for loaded smokers while still catching real regressions.Testing
prove -Ilib t/timeout.tpasses. Full suite passes (only pre-existing t/pty.t IO::Pty version skip).🤖 Generated with Claude Code
Quality Report
Changes: 1 file changed, 1 insertion(+), 1 deletion(-)
Code scan: clean
Tests: failed (0 Failed, 37 tests)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline