fix: finish() now cleans up on exception - #282
Draft
toddr-bot wants to merge 1 commit into
Draft
Conversation
When _select_loop() threw inside finish() (e.g., timeout expiration), the exception propagated past _cleanup(), leaking pipes and leaving child processes unrepaped. run() handled this correctly via eval + kill_kill, but the async API path (start/pump/finish) had no safety net. Now finish() wraps the pump loop in eval and calls kill_kill() on failure, matching run()'s behavior. This ensures children are signaled, reaped, and pipes are closed even when an exception occurs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
finish()now properly cleans up pipes, children, and fds when_select_loop()throws an exception (e.g., timeout).Why
When
_select_loop()threw insidefinish(), the exception propagated past_cleanup(), leaking pipes and leaving child processes unrepaped.run()handled this correctly viaeval+kill_kill, but the async API path (start/pump/finish) had no safety net. Any user callingfinish()with a timeout would leak resources on expiration.How
Wrapped the pump loop in
evaland callkill_kill()on failure, matchingrun()'s pattern.kill_kill()sends SIGTERM, waits for children, then calls_cleanup()— ensuring all resources are released even on error.Testing
t/finish_cleanup.t(4 tests): timeout exception propagation, harness finished state, no fd leak, children reaped🤖 Generated with Claude Code