fix: remove debug 'ack' prefix from IO.pm filter exceptions - #281
Draft
toddr-bot wants to merge 1 commit into
Draft
fix: remove debug 'ack' prefix from IO.pm filter exceptions#281toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
The _do_filters() method in IO.pm prepended "ack " to every re-thrown filter exception. This was a leftover from the original author's debugging that corrupted all filter error messages for io() objects. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Remove a leftover debug string from
_do_filters()in IO.pm that corrupted all filter error messages forio()objects.Why
The
die "ack ", $@ if $@line prepended "ack " to every re-thrown filter exception — a debugging artifact from the original author. Users encountering filter errors would see messages likeack Resource temporarily unavailableinstead of the real error.How
Changed
die "ack ", $@ if $@todie $@ if $@in_do_filters(). Added test int/io.tthat verifies filter exceptions propagate without corruption.Testing
t/io.t(filter exception propagation, no debug prefix)🤖 Generated with Claude Code
Quality Report
Changes: 2 files changed, 19 insertions(+), 3 deletions(-)
Code scan: clean
Tests: failed (0 Failed, 37 tests)
Branch hygiene: clean
Generated by Kōan post-mission quality pipeline