fix: wrap pipe and IO cleanup in eval to prevent cascading failures - #280
Draft
toddr-bot wants to merge 1 commit into
Draft
fix: wrap pipe and IO cleanup in eval to prevent cascading failures#280toddr-bot wants to merge 1 commit into
toddr-bot wants to merge 1 commit into
Conversation
In _cleanup(), the PTY close phase was already protected by eval blocks, but the pipe clobber loop and IO _cleanup() calls were not. If either throws (e.g., a close fails on a corrupted fd), subsequent cleanup steps — child reaping, filter teardown, DEBUG_FD close — would be skipped entirely, leaking resources. Wrap both unprotected phases in eval with carp on error, matching the existing PTY cleanup pattern. This ensures all cleanup phases run even if one fails. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Protect the pipe clobber loop and IO
_cleanup()calls in_cleanup()with eval blocks.Why
In
_cleanup(), the PTY close phase was already protected by eval blocks, but two subsequent phases were not:$self->_clobber(...))_cleanup()callsIf either throws (e.g., close fails on a corrupted fd), subsequent cleanup steps — child reaping, filter teardown, DEBUG_FD close — are skipped entirely, leaking resources.
How
Wrapped both unprotected phases in
evalwithcarpon error, matching the existing PTY cleanup pattern. All cleanup phases now run even if one fails.Testing
🤖 Generated with Claude Code