feat: remove empty properties from etcd-cluster spec to avoid ArgoCD drifting by apenen · Pull Request #301 · cozystack/etcd-operator

Arturo (apenen) · 2025-12-03T14:46:04Z

ArgoCD keeps detecting pending changes because Kubernetes omits empty fields on apply. Removing these fields from the spec prevents unnecessary diffs.

Summary by CodeRabbit

Schema Updates
- Updated the etcd-operator CRD: validation for pod template specification has been relaxed to accept a broader set of fields while retaining the requirement for container definitions and preserving unknown fields. This enables more flexible pod template configurations without changing required structural elements.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Add LICENSE file

Initializing the project

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Update kubebuilder to v3.14.0

Generated and wrote the most basic EtcdCluster custom resource. See cozystack#9

Fixes from comments cozystack#15 - Fix API group name for custom resources - remove unnecessary comment lines

demo: https://github.com/aenix-io/etcd-operator/tree/basic-readme fixes cozystack#10 Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

1. Union argument layers and copy source code. 2. Changed layers order final image for grow cache hit

fixes: cozystack#10 Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

- Added basic validating and defaulting webhooks - Added simple test for defaulting webhook

Controller now can successfully bootstrap etcd cluster :) Controller creates Service, ConfigMap and StatefulSet based on EtcdCluster CR Only EmptyDir storage is supported Initialized status is being set and updated

) This reverts commit 3334e1e.

Proof that it works: https://github.com/hiddenmarten/etcd-operator/pull/1 After that just changed the name of the label, to the easier one.

Update cluster Ready status according to StatefulSet status and update ConfigMap cluster state to `existing` after first time STS is ready fixes cozystack#24

fixes cozystack#23 fixes cozystack#30 --------- Co-authored-by: Kirill Ilin <stitch14@yandex.ru> Co-authored-by: Kirill Garbar <kirill@garbar.pro>

The auxiliary GH action to setup release drafts and update change log accordingly. Configured with autolabeler, so the PRs will be labeled according to the PR branch name and/or files changed: | Branch name | Files changed | Resulting label | | ------------- | ------------- | ------------- | | deps/* | | `dependencies` | | chore/* | | `chore` | | docs/* | **/*.md | `documentation` | | enh/* | | `enhancement` | | feature/* | | `feature` | | fix/* | | `bugfix` | | bugfix/* | | `bugfix` | | | /api/* | `api-change` | | | /internal/* | `controllers` | Based on labels release draft will be updated with 'Features', 'Bug Fixes' and 'Maintenance' categories which will include corresponding PR's title. It's also possible to manage release draft's version by applying `major`, `minor` and `patch` labels on PR. By default the version will be the next patch version after the last release, v0.0.1 if none. --------- Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>

Explicit RW permissions for content and pull requests required, due to repository settings, which grants to workflows only read permissions in the repository for the contents and packages scopes. - RW for content is required for release draft creation (release-drafter). - RW for pull-requests is required for adding labels to PRs (auto-labeler). Signed-off-by: Artem Bortnikov <artem.bortnikov@telekom.com>

…ck#44) in order to access cluster from clients using one IP we decided to use ClusterIP Service

Fixes cozystack#42

Created basic docs site and filled content for main pages

This is important when scaling cluster up for this operation to be zero down time fixes cozystack#25

In case error happens during status update request, reconcile will not be requeued. So, this call should be moved ouside `defer` function fixes cozystack#36

Just an idea to create `CODEOWNERS` to automatically assign reviewers when changing specific part of code. Is there anybody who would like to keep informed about updates? Aproove from codeowners is required to merge every specific change.

Subj. Without such import, there is auth error: ``` Error setting up etcd client: error creating Kubernetes client: no Auth Provider found for name "oidc" ```  ## Summary by CodeRabbit - **New Features** - Introduced commands for managing etcd pods, including status checks, defragmentation, compaction, alarm management, and member management. - **Bug Fixes** - Standardized error handling for improved user feedback during command execution.

* We create several etcd clients in the reconciliation loop, but never had a defer .Close() for them. * We erroneously try to configure these clients with etcd-0 instead of etcd-0.etcd-headless.namespace as the url. Now fixed. Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>

Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>

* Several `defer c.Close()` added to clean up etcd clients after reconciliation. * DNS names targeting etcd cluster members fixed to resolve properly. * TLS capability added to etcd clients created during reconciliation.

## Summary by CodeRabbit - **Documentation** - Added Kirill Klinchenkov and Timofei Larkin as new maintainers in the maintainers list.

Resolves cozystack#273 Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>

…drifting ArgoCD keeps detecting pending changes because Kubernetes omits empty fields on apply. Removing these fields from the spec prevents unnecessary diffs.

coderabbitai · 2025-12-03T14:46:19Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: b0b0bb31-6fa0-4515-86b6-a4068cd8ab5c

📥 Commits

Reviewing files that changed from the base of the PR and between 0570ab0 and 4891761.

📒 Files selected for processing (1)

charts/etcd-operator/crds/etcd-cluster.yaml

💤 Files with no reviewable changes (1)

charts/etcd-operator/crds/etcd-cluster.yaml

📝 Walkthrough

Walkthrough

Removed an empty properties: {} entry from spec.podTemplate.spec in the EtcdCluster CRD schema, leaving required: [containers] and x-kubernetes-preserve-unknown-fields: true intact to allow additional pod spec fields.

Changes

Cohort / File(s)	Summary
CRD Schema Loosening `charts/etcd-operator/crds/etcd-cluster.yaml`	Deleted an explicit empty `properties: {}` under `spec.podTemplate.spec` in the OpenAPIV3Schema, loosening validation while preserving `required: [containers]` and `x-kubernetes-preserve-unknown-fields: true`.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 I nudged a brace and set schema free,
The podTemplate breathes a little more glee.
Empty boxes gone, fields may roam,
Containers still needed — they anchor the home. 🥕

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: removing empty properties from the etcd-cluster spec to prevent ArgoCD drifting issues.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Kirill Ilin (sircthulhu) · 2026-01-20T07:37:26Z

Hi, Arturo (@apenen)! This change will be overriden by commands

make manifests
make helm-crd-copy

So changes need to be made to api/v1alpha1/etcdcluster_types.go

…ystack#308) ## Summary - Replace deprecated `gcr.io/kubebuilder/kube-rbac-proxy:v0.16.0` with `quay.io/brancz/kube-rbac-proxy:v0.18.1` - The GCR-hosted image became unavailable after March 18, 2025 - The new image is from the original upstream author (brancz) Fixes cozystack#271  ## Summary by CodeRabbit * **Chores** * Updated authentication proxy image to quay.io/brancz/kube-rbac-proxy:v0.18.1 across deployment configs and Helm chart values. * **Documentation** * API reference updated to mark numerous embedded and top-level fields as optional, clarifying optionality for specs like replicas, storage, security, TLS, metadata, and pod disruption settings.  --------- Signed-off-by: Andrei Kvapil <kvapss@gmail.com> Co-authored-by: Claude <noreply@anthropic.com>

…stack#307)

Andrei Kvapil (kvaps) and others added 30 commits March 7, 2024 16:21

Initial commit

ad06c3f

Add LICENSE file

a078636

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Initializing the project

36fad37

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Merge pull request cozystack#1 from aenix-io/license

8486505

Add LICENSE file

Merge pull request cozystack#2 from aenix-io/init

fffc4f2

Initializing the project

Update kubebuilder to v3.14.0

395e22b

Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Merge pull request cozystack#3 from aenix-io/init2

13e056f

Update kubebuilder to v3.14.0

GHA docker publish pipeline (cozystack#4)

d18bf37

Basic EtcdCluster custom resource (cozystack#9) (cozystack#15)

756f1a2

Generated and wrote the most basic EtcdCluster custom resource. See cozystack#9

Fix CR api group name (cozystack#16)

57c8ece

Fixes from comments cozystack#15 - Fix API group name for custom resources - remove unnecessary comment lines

Fill basic project information (cozystack#17)

b984cad

demo: https://github.com/aenix-io/etcd-operator/tree/basic-readme fixes cozystack#10 Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Improve Dockerfile (cozystack#5)

c77d9c6

1. Union argument layers and copy source code. 2. Changed layers order final image for grow cache hit

add: link to roadmap (cozystack#18)

b6adcc3

fixes: cozystack#10 Signed-off-by: Andrei Kvapil <kvapss@gmail.com>

Pre-commit via make (cozystack#6)

ffea74d

Validating and defaulting webhooks and tests (cozystack#19)

9f3eb3e

- Added basic validating and defaulting webhooks - Added simple test for defaulting webhook

Implementation of basic controller logic (cozystack#21)

315849f

Controller now can successfully bootstrap etcd cluster :) Controller creates Service, ConfigMap and StatefulSet based on EtcdCluster CR Only EmptyDir storage is supported Initialized status is being set and updated

Add permissions for write packages (cozystack#28)

3334e1e

Revert "Add permissions for write packages (cozystack#28)" (cozystack#29

f06bdb9

) This reverts commit 3334e1e.

Run tests/tests-e2e via make, triggering by label (cozystack#34)

55e689c

Proof that it works: https://github.com/hiddenmarten/etcd-operator/pull/1 After that just changed the name of the label, to the easier one.

Update label name for trigger test pipelines (cozystack#35)

ae9f1e5

Implementation of Ready status condition (cozystack#26)

9e35e26

Update cluster Ready status according to StatefulSet status and update ConfigMap cluster state to `existing` after first time STS is ready fixes cozystack#24

Add how to install operator locally; fix telegram link (cozystack#31)

34d962d

fixes cozystack#23 fixes cozystack#30 --------- Co-authored-by: Kirill Ilin <stitch14@yandex.ru> Co-authored-by: Kirill Garbar <kirill@garbar.pro>

feat: Create ClusterIP Service for clients access to cluster (cozysta…

a6eb964

…ck#44) in order to access cluster from clients using one IP we decided to use ClusterIP Service

ci: Test ok-to-test only on comment actions (cozystack#45)

878826c

Fixes cozystack#42

feat: Add initial docs site setup (cozystack#37)

94c538d

Created basic docs site and filled content for main pages

Move initial config to ConfigMap from sts cli flags (cozystack#56)

b72c708

This is important when scaling cluster up for this operation to be zero down time fixes cozystack#25

enh: Update status in reconcile loop, not in defer (cozystack#41)

4ebf19e

In case error happens during status update request, reconcile will not be requeued. So, this call should be moved ouside `defer` function fixes cozystack#36

Add CODEOWNERS (cozystack#39)

17866ea

Just an idea to create `CODEOWNERS` to automatically assign reviewers when changing specific part of code. Is there anybody who would like to keep informed about updates? Aproove from codeowners is required to merge every specific change.

Evgenii Tereshkov (evgkrsk) and others added 17 commits January 31, 2025 12:24

feature/add-vpa

3a1de90

fix cpu var type

73dbac9

Add VPA for the operator deployment (cozystack#284)

b6e4ea9

Create TLS-capable clients if security enabled

0100a75

Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>

Create TLS-capable clients if security enabled (cozystack#286)

92c9f35

Satisfy the linter

d76c473

Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>

Bugs: wrong address and memory leak (cozystack#285)

4bc99b5

* Several `defer c.Close()` added to clean up etcd clients after reconciliation. * DNS names targeting etcd cluster members fixed to resolve properly. * TLS capability added to etcd clients created during reconciliation.

Merge branch 'main' into chore/issue-263

418fe49

add option to trigger release-assets workflow manually (cozystack#280)

856fede

Update kamaji example

96640cd

Update kamaji example (cozystack#296)

1bbe904

Expose metrics port on client service

86322fd

Resolves cozystack#273 Signed-off-by: Timofei Larkin <lllamnyp@gmail.com>

Expose metrics port on client service (cozystack#299)

6537618

feat: remove empty properties from etcd-cluster spec to avoid ArgoCD …

0570ab0

…drifting ArgoCD keeps detecting pending changes because Kubernetes omits empty fields on apply. Removing these fields from the spec prevents unnecessary diffs.

Arturo (apenen) requested review from Kirill-Garbar, Artem Bortnikov (aobort), Andrei Kvapil (kvaps) and Timofei Larkin (lllamnyp) as code owners December 3, 2025 14:46

Andrei Kvapil (kvaps) and others added 4 commits March 13, 2026 13:07

feat(backup): add EtcdBackup CRD for declarative etcd snapshots (cozy…

dcaffd4

…stack#307)

chore: update codeowners (cozystack#309)

8f6f1bd

Merge branch 'aenix-io:main' into patch-1

4891761

Arturo (apenen) requested a review from Artem Bortnikov (BROngineer) as a code owner April 10, 2026 11:41

Andrei Kvapil (kvaps) closed this Jun 9, 2026

Andrei Kvapil (kvaps) force-pushed the main branch from ce98e5f to 9a6cc65 Compare June 9, 2026 08:00

Navigation Menu

Uh oh!

feat: remove empty properties from etcd-cluster spec to avoid ArgoCD drifting - #301

feat: remove empty properties from etcd-cluster spec to avoid ArgoCD drifting#301
Arturo (apenen) wants to merge 216 commits into
cozystack:mainfrom
apenen:patch-1

Arturo (apenen) commented Dec 3, 2025 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Dec 3, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Kirill Ilin (sircthulhu) commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Uh oh!

Conversation

Arturo (apenen) commented Dec 3, 2025 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Kirill Ilin (sircthulhu) commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Arturo (apenen) commented Dec 3, 2025 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Dec 3, 2025 •

edited

Loading