Skip to content

Preview publications redesign - #2

Merged
sbhavy merged 1 commit into
devfrom
bib-publications
Jul 17, 2026
Merged

sbhavy merged 1 commit into
devfrom
bib-publications

Conversation

@b-sajja

@b-sajja b-sajja commented Jul 13, 2026

Copy link
Copy Markdown

Draft preview for feedback from Xuan. This shows the current publications redesign and related site changes. It is not ready to merge; the branch still needs to be reconciled with the latest dev design.

@sbhavy
sbhavy requested a review from ztangent July 13, 2026 07:03
@sbhavy

sbhavy commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Hi Xuan, this is a draft of my publications redesign and related additions. It targets your dev branch. Could you review the Files changed tab and let me know which parts you’d like integrated into the new design? It currently has merge conflicts, so this is for feedback rather than merging as-is.

@ztangent

Copy link
Copy Markdown
Contributor

Overall looks good to me! Some things to preserve about the current dev branch:

  • The publications are under the research' page now instead of their own publications` page, and I'm inclined to keep that approach.
  • The about page is standalone page that is separate from the homepage, with a brief description of what the lab does, and no photo. I think we can eventually include a photo there but I'm not a huge fan of the current one in your branch.
  • The home page is just a page with a logo, and no additional content.
  • The CSS changes in the dev branch should be preserved.

Other comments:

  • Can we standardize the team member images so that they're the same aspect ratio and resolution (e.g. all 300 x 300px)?
  • Might also be a good idea to squash commits when merging so that we don't have too many large binary files (for the images) in the commit history.
  • Maybe we can write a contributor guide in README.md or CONTRIBUTING.md for how to add / update your own biography via a PR, or how to add / update project pages and publications.

Thanks again for taking charge of this!

@sbhavy
sbhavy force-pushed the bib-publications branch from 7697e3f to 42daf2c Compare July 16, 2026 08:44
@sbhavy

sbhavy commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Hey, Xuan -- thanks a lot for the feedback!

I have done my best to incorporate all of it. Please check the site now and confirm if it's okay.

PS1: We can consider removing the update citations job, since we are now using a bib file.

@ztangent

Copy link
Copy Markdown
Contributor

Awesome thank you!

Yes I think we can remove the update citations job.

I'm not sure if this is a GitHub display issue or something with the profile images themselves, but they all look like they have one column of transparent pixels at the far left of each image.

Otherwise it looks great! (Haven't tried to compile and view the site itself but I trust that it'll be fine.)

@sbhavy

sbhavy commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Great!

I've manually checked the images on local, and they seem to be fine -- no strips of transparent pixels. So, it is probably a GitHub thing.

Feel free to compile the site and check it out :) If all's okay, we can merge the commit.

@ztangent

Copy link
Copy Markdown
Contributor

I think you can just go ahead and merge! I trust that it'll look fine, thanks :)

@sbhavy
sbhavy marked this pull request as ready for review July 17, 2026 10:12
@sbhavy
sbhavy merged commit 85e908a into dev Jul 17, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants